Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2610883003: [Offline Pages] Fix format error when logging in test harness. (Closed)

Created:
3 years, 11 months ago by romax
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Fix format error when logging in test harness. Fix MissingFormatArgumentException in Evaluation test for latest logging changes. BUG=678279 Committed: https://crrev.com/66da925008d53332a8d1f39f75866e0d734ef78c Cr-Commit-Position: refs/heads/master@{#441460}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageSavePageLaterEvaluationTest.java View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
romax
PTAL, thanks.
3 years, 11 months ago (2017-01-04 17:39:17 UTC) #2
dougarnett
lgtm
3 years, 11 months ago (2017-01-04 17:56:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610883003/1
3 years, 11 months ago (2017-01-04 18:18:20 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-04 18:18:21 UTC) #7
Pete Williamson
lgtm
3 years, 11 months ago (2017-01-04 20:53:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610883003/1
3 years, 11 months ago (2017-01-04 20:54:11 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 21:00:05 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 21:01:40 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66da925008d53332a8d1f39f75866e0d734ef78c
Cr-Commit-Position: refs/heads/master@{#441460}

Powered by Google App Engine
This is Rietveld 408576698