|
|
Description[Offline Pages] Fix format error when logging in test harness.
Fix MissingFormatArgumentException in Evaluation test for latest logging
changes.
BUG=678279
Committed: https://crrev.com/66da925008d53332a8d1f39f75866e0d734ef78c
Cr-Commit-Position: refs/heads/master@{#441460}
Patch Set 1 #
Messages
Total messages: 19 (11 generated)
romax@chromium.org changed reviewers: + dougarnett@chromium.org, petewil@chromium.org
PTAL, thanks.
lgtm
The CQ bit was checked by romax@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by romax@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by romax@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1483563221137160, "parent_rev": "2f5687d13ce99f64eccafec0abcae871ee5f92c1", "commit_rev": "5309a684291081b571f23fe8b689f9ea7fe1a18f"}
Message was sent while issue was closed.
Description was changed from ========== [Offline Pages] Fix format error when logging in test harness. Fix MissingFormatArgumentException in Evaluation test for latest logging changes. BUG=678279 ========== to ========== [Offline Pages] Fix format error when logging in test harness. Fix MissingFormatArgumentException in Evaluation test for latest logging changes. BUG=678279 Review-Url: https://codereview.chromium.org/2610883003 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Offline Pages] Fix format error when logging in test harness. Fix MissingFormatArgumentException in Evaluation test for latest logging changes. BUG=678279 Review-Url: https://codereview.chromium.org/2610883003 ========== to ========== [Offline Pages] Fix format error when logging in test harness. Fix MissingFormatArgumentException in Evaluation test for latest logging changes. BUG=678279 Committed: https://crrev.com/66da925008d53332a8d1f39f75866e0d734ef78c Cr-Commit-Position: refs/heads/master@{#441460} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/66da925008d53332a8d1f39f75866e0d734ef78c Cr-Commit-Position: refs/heads/master@{#441460} |