Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2610853012: Remove DCHECK in WmWindowMus::CloseWidget() (Closed)

Created:
3 years, 11 months ago by sky
Modified:
3 years, 11 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DCHECK in WmWindowMus::CloseWidget() And improve comment. Additionally removes some dead includes in RootWindowController. BUG=671246 TEST=none R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2610853012 Cr-Commit-Position: refs/heads/master@{#442029} Committed: https://chromium.googlesource.com/chromium/src/+/21adf48e93469ae8be2fbbf7d47806a574127b0f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M ash/mus/bridge/wm_window_mus.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ash/root_window_controller.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
sky
3 years, 11 months ago (2017-01-06 18:59:54 UTC) #1
James Cook
LGTM
3 years, 11 months ago (2017-01-06 19:25:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610853012/1
3 years, 11 months ago (2017-01-06 20:23:21 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 20:30:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/21adf48e93469ae8be2fbbf7d478...

Powered by Google App Engine
This is Rietveld 408576698