[wrapper-tracing] Enable cleanup and invalidating on WorkerBackingThread

[wrapper-tracing] Enable cleanup and invalidating on WorkerBackingThread

While worker threads have no DOM access, they still get a scripting environment
and need wrapper tracing. Failing to invalidate and/or cleanup wrappers will leave
dangling pointers behind.

BUG=676700, 468240
Committed: https://crrev.com/9b65fe51909ad937b34d14dd8fcde88b3f2aedf6
Cr-Commit-Position: refs/heads/master@{#441402}

[Michael Lippautz, 2017-01-04 13:58:29]

Description was changed from

==========
[wrapper-tracing] Enable cleanup and invalidating on WorkerBackingThread

While worker threads have no DOM access, they still get a scripting environment
and wrapper tracing. Failing to invalidate and/or cleanup wrappers will leaving
dangling pointers behind.

BUG=
==========

to

==========
[wrapper-tracing] Enable cleanup and invalidating on WorkerBackingThread

While worker threads have no DOM access, they still get a scripting environment
and wrapper tracing. Failing to invalidate and/or cleanup wrappers will leaving
dangling pointers behind.

BUG=676700, 468240
==========

[Michael Lippautz, 2017-01-04 13:58:52]

mlippautz@chromium.org changed reviewers:
+ haraken@chromium.org, hlopko@chromium.org

[Michael Lippautz, 2017-01-04 13:58:56]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 13:59:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Lippautz, 2017-01-04 14:01:53]

Description was changed from

==========
[wrapper-tracing] Enable cleanup and invalidating on WorkerBackingThread

While worker threads have no DOM access, they still get a scripting environment
and wrapper tracing. Failing to invalidate and/or cleanup wrappers will leaving
dangling pointers behind.

BUG=676700, 468240
==========

to

==========
[wrapper-tracing] Enable cleanup and invalidating on WorkerBackingThread

While worker threads have no DOM access, they still get a scripting environment
and wrapper tracing. Failing to invalidate and/or cleanup wrappers will leave
dangling pointers behind.

BUG=676700, 468240
==========

[Michael Lippautz, 2017-01-04 14:09:57]

Description was changed from

==========
[wrapper-tracing] Enable cleanup and invalidating on WorkerBackingThread

While worker threads have no DOM access, they still get a scripting environment
and wrapper tracing. Failing to invalidate and/or cleanup wrappers will leave
dangling pointers behind.

BUG=676700, 468240
==========

to

==========
[wrapper-tracing] Enable cleanup and invalidating on WorkerBackingThread

While worker threads have no DOM access, they still get a scripting environment
and need wrapper tracing. Failing to invalidate and/or cleanup wrappers will
leave
dangling pointers behind.

BUG=676700, 468240
==========

[haraken, 2017-01-04 14:30:46]

LGTM

[haraken, 2017-01-04 14:32:59]

https://codereview.chromium.org/2610853002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp (left):

https://codereview.chromium.org/2610853002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp:76: m_isolate,
V8GCController::traceDOMWrappers, nullptr, nullptr);

Can we forbid registerTraceDOMWrappers() accepting nullptr?

[Michael Lippautz, 2017-01-04 14:44:09]

https://codereview.chromium.org/2610853002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp (left):

https://codereview.chromium.org/2610853002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp:76: m_isolate,
V8GCController::traceDOMWrappers, nullptr, nullptr);
On 2017/01/04 14:32:59, haraken wrote:
> 
> Can we forbid registerTraceDOMWrappers() accepting nullptr?

We have some testing paths where we don't passt the callbacks, but I added
DCHECKs that make sure we have the callbacks whenever we also pass an Isolate.

[Michael Lippautz, 2017-01-04 14:44:12]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2017-01-04 14:44:12]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2610853002/#ps20001
(title: "Address comment")

[commit-bot: I haz the power, 2017-01-04 14:44:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marcel Hlopko, 2017-01-04 15:25:52]

lgtm

[commit-bot: I haz the power, 2017-01-04 17:36:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483541052349850,
"parent_rev": "34ab9ea8ab10cb5c91c27a9adb6b6861151bb840", "commit_rev":
"8b60862efb028af92671fa8df632009878dd803e"}

[commit-bot: I haz the power, 2017-01-04 17:36:42]

Description was changed from

==========
[wrapper-tracing] Enable cleanup and invalidating on WorkerBackingThread

While worker threads have no DOM access, they still get a scripting environment
and need wrapper tracing. Failing to invalidate and/or cleanup wrappers will
leave
dangling pointers behind.

BUG=676700, 468240
==========

to

==========
[wrapper-tracing] Enable cleanup and invalidating on WorkerBackingThread

While worker threads have no DOM access, they still get a scripting environment
and need wrapper tracing. Failing to invalidate and/or cleanup wrappers will
leave
dangling pointers behind.

BUG=676700, 468240

Review-Url: https://codereview.chromium.org/2610853002
==========

[commit-bot: I haz the power, 2017-01-04 17:36:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-04 17:40:55]

Description was changed from

==========
[wrapper-tracing] Enable cleanup and invalidating on WorkerBackingThread

While worker threads have no DOM access, they still get a scripting environment
and need wrapper tracing. Failing to invalidate and/or cleanup wrappers will
leave
dangling pointers behind.

BUG=676700, 468240

Review-Url: https://codereview.chromium.org/2610853002
==========

to

==========
[wrapper-tracing] Enable cleanup and invalidating on WorkerBackingThread

While worker threads have no DOM access, they still get a scripting environment
and need wrapper tracing. Failing to invalidate and/or cleanup wrappers will
leave
dangling pointers behind.

BUG=676700, 468240

Committed: https://crrev.com/9b65fe51909ad937b34d14dd8fcde88b3f2aedf6
Cr-Commit-Position: refs/heads/master@{#441402}
==========

[commit-bot: I haz the power, 2017-01-04 17:40:56]

Patchset 2 (id:??) landed as
https://crrev.com/9b65fe51909ad937b34d14dd8fcde88b3f2aedf6
Cr-Commit-Position: refs/heads/master@{#441402}