Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2610813010: Tidy cfgas_fontmgr, remove custom sorting code. (Closed)

Created:
3 years, 11 months ago by Tom Sepez
Modified:
3 years, 11 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -87 lines) Patch
M core/fxcrt/fx_ext.h View 1 chunk +0 lines, -23 lines 0 comments Download
M xfa/fgas/font/cfgas_fontmgr.h View 3 chunks +12 lines, -16 lines 0 comments Download
M xfa/fgas/font/cfgas_fontmgr.cpp View 9 chunks +35 lines, -48 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Tom Sepez
Dan, for review (I verified current order is ascending in the sort I removed).
3 years, 11 months ago (2017-01-06 19:29:55 UTC) #4
dsinclair
lgtm
3 years, 11 months ago (2017-01-09 14:32:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610813010/1
3 years, 11 months ago (2017-01-09 14:32:32 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 14:54:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/5037839bb0b91792b81a3e455dead1314fcc...

Powered by Google App Engine
This is Rietveld 408576698