Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2610783004: Remove ContextClient from NavigatorInstalledApp (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContextClient from NavigatorInstalledApp Now that Navigator supplement can get the Navigator object via host(), it doesn't need to observe ContextClient. BUG=610176 Review-Url: https://codereview.chromium.org/2610783004 Cr-Commit-Position: refs/heads/master@{#441693} Committed: https://chromium.googlesource.com/chromium/src/+/5fbd585f9e92926f179785e1a9394057fe254f10

Patch Set 1 #

Patch Set 2 : temp #

Total comments: 1

Patch Set 3 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -15 lines) Patch
M third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.h View 1 3 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp View 1 2 5 chunks +8 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
haraken
PTAL
3 years, 11 months ago (2017-01-05 12:07:15 UTC) #2
sof
lgtm https://codereview.chromium.org/2610783004/diff/20001/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp File third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp (right): https://codereview.chromium.org/2610783004/diff/20001/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp#newcode74 third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp:74: if (!controller()) { // If the associated frame ...
3 years, 11 months ago (2017-01-05 12:30:56 UTC) #3
haraken
> https://codereview.chromium.org/2610783004/diff/20001/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp > File third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp > (right): > > https://codereview.chromium.org/2610783004/diff/20001/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp#newcode74 > third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp:74: if > (!controller()) ...
3 years, 11 months ago (2017-01-05 12:37:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610783004/40001
3 years, 11 months ago (2017-01-05 12:38:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/358228)
3 years, 11 months ago (2017-01-05 15:41:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610783004/40001
3 years, 11 months ago (2017-01-05 15:53:35 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 17:41:22 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5fbd585f9e92926f179785e1a939...

Powered by Google App Engine
This is Rietveld 408576698