mus: Make sure window parenting happens in the window server.

mus: Make sure window parenting happens in the window server.

The native window parenting should happen in the window server,
since a sandboxed gpu process won't be able to do it.

BUG=643746
Review-Url: https://codereview.chromium.org/2610783003
Cr-Commit-Position: refs/heads/master@{#442060}
Committed: https://chromium.googlesource.com/chromium/src/+/9bae0d9b67c3e52182fb0cfd2b516efd3e521f43

[sadrul, 2017-01-04 21:15:32]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 21:16:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 22:16:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 22:16:19]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-01-05 02:19:23]

sadrul@chromium.org changed reviewers:
+ tsepez@chromium.org

[sadrul, 2017-01-05 03:43:01]

Actually, this needs some more work. I will ping again when this is ready for
review.

[sadrul, 2017-01-05 03:43:16]

Description was changed from

==========
mus: Make sure window parenting happens in the window server.

The native window parenting should happen in the window server,
since a sandboxed gpu process won't be able to do it.

BUG=643746
==========

to

==========
mus: Make sure window parenting happens in the window server.

The native window parenting should happen in the window server,
since a sandboxed gpu process won't be able to do it.

BUG=643746
==========

[sadrul, 2017-01-05 03:43:16]

sadrul@chromium.org changed reviewers:
- tsepez@chromium.org

[sadrul, 2017-01-06 18:09:24]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 18:10:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-01-06 18:25:13]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 18:25:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-01-06 18:27:02]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org, tsepez@chromium.org

[sadrul, 2017-01-06 18:27:02]

sky@ for the plumbing of AcceleratedWidget from PlatformDisplayDefault to
GpuHost

tsepez@ for the mojom change, and the corresponding change in GpuHost
implementation.

kylechar@ FYI

[Tom Sepez, 2017-01-06 18:31:24]

We made these IDs unguessable, right?

[commit-bot: I haz the power, 2017-01-06 19:38:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 19:38:06]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-01-06 20:30:48]

On 2017/01/06 18:31:24, Tom Sepez wrote:
> We made these IDs unguessable, right?

I think you are referring to SurfaceId. This is SurfaceHandle, which, on
Windows, is an HWND [1, 2]. The current chrome IPC corresponding to this is [3].
That's why the window server makes sure the handles are valid before doing
anything with them (the change in GpuHost::SetChildSurface())

[1]
https://cs.chromium.org/chromium/src/gpu/ipc/common/surface_handle.h?sq=packa...
[2]
https://cs.chromium.org/chromium/src/ui/gfx/native_widget_types.h?sq=package:...
[3]
https://cs.chromium.org/chromium/src/content/common/gpu_host_messages.h?sq=pa...

[sky, 2017-01-06 20:45:38]

LGTM

[Tom Sepez, 2017-01-06 20:58:27]

Ah, ok. LGTM

[sadrul, 2017-01-06 21:28:00]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2017-01-06 21:28:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 21:35:37]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483738080770850,
"parent_rev": "449b31c06863f9d26120345bdcdfb72196aeeb87", "commit_rev":
"9bae0d9b67c3e52182fb0cfd2b516efd3e521f43"}

[commit-bot: I haz the power, 2017-01-06 21:36:05]

Description was changed from

==========
mus: Make sure window parenting happens in the window server.

The native window parenting should happen in the window server,
since a sandboxed gpu process won't be able to do it.

BUG=643746
==========

to

==========
mus: Make sure window parenting happens in the window server.

The native window parenting should happen in the window server,
since a sandboxed gpu process won't be able to do it.

BUG=643746

Review-Url: https://codereview.chromium.org/2610783003
Cr-Commit-Position: refs/heads/master@{#442060}
Committed:
https://chromium.googlesource.com/chromium/src/+/9bae0d9b67c3e52182fb0cfd2b51...
==========

[commit-bot: I haz the power, 2017-01-06 21:36:08]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9bae0d9b67c3e52182fb0cfd2b51...