[Extensions Bindings] Make function definitions optional for an API.

[Extensions Bindings] Make function definitions optional for an API.

chrome.storage, for instance, has events but no functions directly on the
API object. See extensions/common/api/storage.json.

BUG=653596
Committed: https://crrev.com/f89894a0691ae2682427235ff5724a8cd46368ca
Cr-Commit-Position: refs/heads/master@{#441459}

[jbroman, 2017-01-03 20:40:24]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 20:40:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 21:26:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 21:27:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jbroman, 2017-01-03 21:37:28]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 21:37:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2017-01-03 22:00:44]

jbroman@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2017-01-03 22:38:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 22:38:50]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-01-04 15:49:14]

https://codereview.chromium.org/2610743002/diff/20001/extensions/renderer/api...
File extensions/renderer/api_binding.h (right):

https://codereview.chromium.org/2610743002/diff/20001/extensions/renderer/api...
extensions/renderer/api_binding.h:61: // may be null if the API does not specify
any types or events.
s/types or events/of the given category
or something to that effect.

https://codereview.chromium.org/2610743002/diff/20001/extensions/renderer/api...
File extensions/renderer/api_binding_unittest.cc (right):

https://codereview.chromium.org/2610743002/diff/20001/extensions/renderer/api...
extensions/renderer/api_binding_unittest.cc:554: 
Let's add a new unittest for this.  It's a pretty simple change, but it's also
pretty simple to test. :)  (And currently no other tests pass in null functions,
whereas there are tests that pass in null events/types).

[jbroman, 2017-01-04 19:53:18]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 19:53:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2017-01-04 19:55:43]

https://codereview.chromium.org/2610743002/diff/20001/extensions/renderer/api...
File extensions/renderer/api_binding.h (right):

https://codereview.chromium.org/2610743002/diff/20001/extensions/renderer/api...
extensions/renderer/api_binding.h:61: // may be null if the API does not specify
any types or events.
On 2017/01/04 at 15:49:14, Devlin (sheriff - maybe slow) wrote:
> s/types or events/of the given category
> or something to that effect.

Done.

https://codereview.chromium.org/2610743002/diff/20001/extensions/renderer/api...
File extensions/renderer/api_binding_unittest.cc (right):

https://codereview.chromium.org/2610743002/diff/20001/extensions/renderer/api...
extensions/renderer/api_binding_unittest.cc:554: 
On 2017/01/04 at 15:49:14, Devlin (sheriff - maybe slow) wrote:
> Let's add a new unittest for this.  It's a pretty simple change, but it's also
pretty simple to test. :)  (And currently no other tests pass in null functions,
whereas there are tests that pass in null events/types).

Done.

I added a unit test which passes in null for everything (an empty API), and
checks that no own properties are added to the object.

[Devlin, 2017-01-04 19:56:43]

lgtm

[jbroman, 2017-01-04 20:36:05]

The CQ bit was unchecked by jbroman@chromium.org

[jbroman, 2017-01-04 20:36:06]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2017-01-04 20:36:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 20:54:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483562166720340,
"parent_rev": "42a38e94acb3df1528f6df035a78d3cde644ab93", "commit_rev":
"2f5687d13ce99f64eccafec0abcae871ee5f92c1"}

[commit-bot: I haz the power, 2017-01-04 20:54:50]

Description was changed from

==========
[Extensions Bindings] Make function definitions optional for an API.

chrome.storage, for instance, has events but no functions directly on the
API object. See extensions/common/api/storage.json.

BUG=653596
==========

to

==========
[Extensions Bindings] Make function definitions optional for an API.

chrome.storage, for instance, has events but no functions directly on the
API object. See extensions/common/api/storage.json.

BUG=653596

Review-Url: https://codereview.chromium.org/2610743002
==========

[commit-bot: I haz the power, 2017-01-04 20:54:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2017-01-04 20:57:40]

Description was changed from

==========
[Extensions Bindings] Make function definitions optional for an API.

chrome.storage, for instance, has events but no functions directly on the
API object. See extensions/common/api/storage.json.

BUG=653596

Review-Url: https://codereview.chromium.org/2610743002
==========

to

==========
[Extensions Bindings] Make function definitions optional for an API.

chrome.storage, for instance, has events but no functions directly on the
API object. See extensions/common/api/storage.json.

BUG=653596

Committed: https://crrev.com/f89894a0691ae2682427235ff5724a8cd46368ca
Cr-Commit-Position: refs/heads/master@{#441459}
==========

[commit-bot: I haz the power, 2017-01-04 20:57:41]

Patchset 3 (id:??) landed as
https://crrev.com/f89894a0691ae2682427235ff5724a8cd46368ca
Cr-Commit-Position: refs/heads/master@{#441459}