Unify SurfaceInfo

Unify SurfaceInfo

Previously, we had two SurfaceInfo objects:

ui/aura/mus/surface_id_handler.h's SurfaceInfo

and cc/surfaces/surface_info.h

This CL switches to using cc::SurfaceInfo instead, transmitting it over
mojo and replaces all call sites where the fields are passed
individually.

SurfaceInfo becomes part of the Mus API: It is the bundle of state
necessary to embed a Surface across processes.

BUG=676375
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a
Cr-Commit-Position: refs/heads/master@{#441301}

[Fady Samuel, 2017-01-03 20:23:55]

Description was changed from

==========
WIP: Unify SurfaceInfo

BUG=
==========

to

==========
WIP: Unify SurfaceInfo

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2017-01-03 20:24:24]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 20:24:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2017-01-03 20:59:34]

Description was changed from

==========
WIP: Unify SurfaceInfo

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Unify SurfaceInfo

Previously, we had two SurfaceInfo objects:

ui/aura/mus/surface_id_handler.h's SurfaceInfo

and cc/surfaces/surface_info.h

This CL switches to using cc::SurfaceInfo instead, transmitting it over 
mojo and replaces all call sites where the fields are passed 
individually.

SurfaceInfo becomes part of the Mus API: It is the bundle of state 
necessary to embed a Surface across processes.

BUG=676375
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Fady Samuel, 2017-01-03 20:59:41]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 20:59:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Fady Samuel, 2017-01-03 21:00:43]

fsamuel@chromium.org changed reviewers:
+ jam@chromium.org, jbauman@chromium.org, sky@chromium.org, tsepez@chromium.org

[Fady Samuel, 2017-01-03 21:00:44]

+jbauman@ for cc
+tsepez@ for mojo / ipc
+jam@ for content/
+sky@ for services and ui.

[Tom Sepez, 2017-01-03 21:14:06]

LGTM since this is just shuffling existing fields around, but where do we
validate frame_size / size_in_pixels?  What happens if they are spoofed? 
Thanks.

[Fady Samuel, 2017-01-03 21:17:03]

On 2017/01/03 21:14:06, Tom Sepez wrote:
> LGTM since this is just shuffling existing fields around, but where do we
> validate frame_size / size_in_pixels?  What happens if they are spoofed? 
> Thanks.

We don't valid the frame_size directly. Instead, it is the embedder's
responsibility to clip, gutter or scale the Surface it embeds as it sees fit.

[Fady Samuel, 2017-01-03 21:24:25]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 21:24:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 22:35:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 22:35:54]

Dry run: This issue passed the CQ dry run.

[sky, 2017-01-03 23:22:06]

LGTM

https://codereview.chromium.org/2610723002/diff/60001/services/ui/public/inte...
File services/ui/public/interfaces/window_tree.mojom (right):

https://codereview.chromium.org/2610723002/diff/60001/services/ui/public/inte...
services/ui/public/interfaces/window_tree.mojom:7: import
"cc/ipc/surface_info.mojom";
sort

[Fady Samuel, 2017-01-03 23:28:03]

fsamuel@chromium.org changed reviewers:
+ junov@chromium.org

[Fady Samuel, 2017-01-03 23:28:03]

+junov@ for offscreen canvas things.

[Fady Samuel, 2017-01-03 23:28:09]

The CQ bit was checked by fsamuel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 23:28:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2017-01-03 23:32:27]

lgtm

[jam, 2017-01-03 23:46:59]

lgtm

[commit-bot: I haz the power, 2017-01-04 01:36:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 01:36:36]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2017-01-04 02:34:14]

The CQ bit was checked by fsamuel@chromium.org

[Fady Samuel, 2017-01-04 02:34:14]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2610723002/#ps80001
(title: "Cleanup offscreen canvas")

[commit-bot: I haz the power, 2017-01-04 02:34:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 02:41:36]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1483497254150180,
"parent_rev": "94f348ff0caa847c5966ba953223d8b6eb76a82c", "commit_rev":
"eb7302542e9fd1fec463b93eb06b07da78796b3a"}

[commit-bot: I haz the power, 2017-01-04 02:42:05]

Description was changed from

==========
Unify SurfaceInfo

Previously, we had two SurfaceInfo objects:

ui/aura/mus/surface_id_handler.h's SurfaceInfo

and cc/surfaces/surface_info.h

This CL switches to using cc::SurfaceInfo instead, transmitting it over 
mojo and replaces all call sites where the fields are passed 
individually.

SurfaceInfo becomes part of the Mus API: It is the bundle of state 
necessary to embed a Surface across processes.

BUG=676375
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Unify SurfaceInfo

Previously, we had two SurfaceInfo objects:

ui/aura/mus/surface_id_handler.h's SurfaceInfo

and cc/surfaces/surface_info.h

This CL switches to using cc::SurfaceInfo instead, transmitting it over 
mojo and replaces all call sites where the fields are passed 
individually.

SurfaceInfo becomes part of the Mus API: It is the bundle of state 
necessary to embed a Surface across processes.

BUG=676375
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2610723002
==========

[commit-bot: I haz the power, 2017-01-04 02:42:08]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2017-01-04 02:45:52]

Description was changed from

==========
Unify SurfaceInfo

Previously, we had two SurfaceInfo objects:

ui/aura/mus/surface_id_handler.h's SurfaceInfo

and cc/surfaces/surface_info.h

This CL switches to using cc::SurfaceInfo instead, transmitting it over 
mojo and replaces all call sites where the fields are passed 
individually.

SurfaceInfo becomes part of the Mus API: It is the bundle of state 
necessary to embed a Surface across processes.

BUG=676375
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2610723002
==========

to

==========
Unify SurfaceInfo

Previously, we had two SurfaceInfo objects:

ui/aura/mus/surface_id_handler.h's SurfaceInfo

and cc/surfaces/surface_info.h

This CL switches to using cc::SurfaceInfo instead, transmitting it over
mojo and replaces all call sites where the fields are passed
individually.

SurfaceInfo becomes part of the Mus API: It is the bundle of state
necessary to embed a Surface across processes.

BUG=676375
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Committed: https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a
Cr-Commit-Position: refs/heads/master@{#441301}
==========

[commit-bot: I haz the power, 2017-01-04 02:45:53]

Patchset 5 (id:??) landed as
https://crrev.com/96795520bafe2e33f755948f2d732cb42d10504a
Cr-Commit-Position: refs/heads/master@{#441301}

[Justin Novosad, 2017-01-06 20:11:44]

junov@chromium.org changed reviewers:
+ xlai@chromium.org

[Justin Novosad, 2017-01-06 20:11:44]

+xlai as FYI