Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2610703002: [turbofan] second attempt to fix second divergence in escape analysis (Closed)

Created:
3 years, 11 months ago by Tobias Tebbi
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] second attempt to fix second divergence in escape analysis The previous patch for this bug (https://codereview.chromium.org/2599793002/) was wrong because it changed the behavior of isCreatedPhi() in an incompatible way. The actual source of the bug is that escape analysis propagates information along cycles without considering the previous analysis value. This fix makes sure that if a previous merge cleared a field, then it stays cleared. R=bmeurer@chromium.org BUG=chromium:670202 Review-Url: https://codereview.chromium.org/2610703002 Cr-Commit-Position: refs/heads/master@{#42045} Committed: https://chromium.googlesource.com/v8/v8/+/199af0abb2bd2749673175e30389f9371041f737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M src/compiler/escape-analysis.cc View 4 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tobias Tebbi
3 years, 11 months ago (2017-01-03 15:09:27 UTC) #1
Benedikt Meurer
lgtm
3 years, 11 months ago (2017-01-03 18:18:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610703002/1
3 years, 11 months ago (2017-01-03 18:56:55 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 19:22:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/199af0abb2bd2749673175e30389f937104...

Powered by Google App Engine
This is Rietveld 408576698