 Chromium Code Reviews
 Chromium Code Reviews Issue 2610653002:
  Tidy up XMLHttpRequest::endLoading().  (Closed)
    
  
    Issue 2610653002:
  Tidy up XMLHttpRequest::endLoading().  (Closed) 
  | Index: third_party/WebKit/Source/core/loader/DocumentLoader.cpp | 
| diff --git a/third_party/WebKit/Source/core/loader/DocumentLoader.cpp b/third_party/WebKit/Source/core/loader/DocumentLoader.cpp | 
| index 7328e4995ea61c863ae934427b1c18dea2be2ccf..5ca380e22153fc08ed03cae6e86fff76ef20d7c4 100644 | 
| --- a/third_party/WebKit/Source/core/loader/DocumentLoader.cpp | 
| +++ b/third_party/WebKit/Source/core/loader/DocumentLoader.cpp | 
| @@ -35,6 +35,7 @@ | 
| #include "core/events/Event.h" | 
| #include "core/fetch/FetchInitiatorTypeNames.h" | 
| #include "core/fetch/FetchRequest.h" | 
| +#include "core/fetch/FetchUtils.h" | 
| #include "core/fetch/MemoryCache.h" | 
| #include "core/fetch/ResourceFetcher.h" | 
| #include "core/frame/Deprecation.h" | 
| @@ -506,7 +507,7 @@ void DocumentLoader::responseReceived( | 
| if (m_response.isHTTP()) { | 
| int status = m_response.httpStatusCode(); | 
| - if ((status < 200 || status >= 300) && m_frame->owner()) | 
| + if (!FetchUtils::isSuccessfulStatusCode(status) && m_frame->owner()) | 
| 
tyoshino (SeeGerritForStatus)
2017/01/05 05:54:24
just pass "m_response.httpStatusCode()" directly?
 
sof
2017/01/05 08:11:03
Done, conflated the double "if".
 | 
| m_frame->owner()->renderFallbackContent(); | 
| } | 
| } |