Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issue 2610643002: Various IWYU fixes. (Closed)

Created:
3 years, 11 months ago by marja
Modified:
3 years, 11 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Various IWYU fixes. (Missing includes discovered during the objects.h splitting work.) BUG=v8:5402 Review-Url: https://codereview.chromium.org/2610643002 Cr-Commit-Position: refs/heads/master@{#42029} Committed: https://chromium.googlesource.com/v8/v8/+/a8a45d875f0a98b192cf0063ceda12aaf75ddfaf

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixes + more iwyu #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/ast/ast.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ast/ast-value-factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ast/scopeinfo.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/global-handles.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parse-info.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parse-info.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/parsing/parser-base.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/heap/test-alloc.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/heap/test-array-buffer-tracker.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
marja
epertoso, ptal (you're a compiler owner)
3 years, 11 months ago (2017-01-03 11:31:04 UTC) #4
epertoso
https://codereview.chromium.org/2610643002/diff/1/src/compiler/node.h File src/compiler/node.h (right): https://codereview.chromium.org/2610643002/diff/1/src/compiler/node.h#newcode21 src/compiler/node.h:21: class Operator; We're including operator.h, this seems wrong.
3 years, 11 months ago (2017-01-03 11:34:49 UTC) #5
marja
On 2017/01/03 11:34:49, epertoso wrote: > https://codereview.chromium.org/2610643002/diff/1/src/compiler/node.h > File src/compiler/node.h (right): > > https://codereview.chromium.org/2610643002/diff/1/src/compiler/node.h#newcode21 > ...
3 years, 11 months ago (2017-01-03 11:36:59 UTC) #6
marja
On 2017/01/03 11:36:59, marja wrote: > On 2017/01/03 11:34:49, epertoso wrote: > > https://codereview.chromium.org/2610643002/diff/1/src/compiler/node.h > ...
3 years, 11 months ago (2017-01-03 12:13:25 UTC) #10
epertoso
lgtm
3 years, 11 months ago (2017-01-03 13:11:22 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610643002/40001
3 years, 11 months ago (2017-01-03 13:15:23 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 13:17:05 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/a8a45d875f0a98b192cf0063ceda12aaf75...

Powered by Google App Engine
This is Rietveld 408576698