Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1097)

Issue 2610563002: Reland of "[heap] Report wrappers after processing the marking deque incrementally" (Closed)

Created:
3 years, 11 months ago by Michael Lippautz
Modified:
3 years, 11 months ago
CC:
Hannes Payer (out of office), ulan, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of "[heap] Report wrappers after processing the marking deque incrementally" We need to report cached wrappers within v8 to the embedder after each atomic phase of v8 marking because the embedder can invalidate the wrappers in-between v8 marking steps. E.g., in Chrome, a conservative GC might need to wipe dead wrappables from the wrapper tracing marking deque. BUG=chromium:676700, chromium:468240 Review-Url: https://codereview.chromium.org/2610563002 Cr-Commit-Position: refs/heads/master@{#42011} Committed: https://chromium.googlesource.com/v8/v8/+/5622bc15f1d50f79056f943e7242c05ed66352a2

Patch Set 1 : Broken #

Patch Set 2 : Fix: Register cached wrappers with the embedder after Scavenge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M src/heap/embedder-tracing.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/heap/incremental-marking.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/heap/embedder-tracing-unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Michael Lippautz
ptal ps1 was reverted; ps2 contains the fix.
3 years, 11 months ago (2017-01-02 12:48:14 UTC) #9
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-02 12:50:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610563002/20001
3 years, 11 months ago (2017-01-02 13:04:35 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 13:06:16 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/5622bc15f1d50f79056f943e7242c05ed66...

Powered by Google App Engine
This is Rietveld 408576698