Issue 2610513004: Fix dart:typed_data runtimeType getters.

Issue 2610513004: Fix dart:typed_data runtimeType getters. (Closed)

Created:
3 years, 11 months ago by Kevin Millikin (Google)

Modified:
3 years, 11 months ago

Reviewers:
Vyacheslav Egorov (Google), Florian Schneider, kustermann

CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix dart:typed_data runtimeType getters. The proper way to override runtimeType in the VM is not to provide an overriding getter in Dart code but to rely on Class::UserVisibleName. This works both with optimizations and also with external typed data. Closes https://github.com/dart-lang/sdk/issues/28183 BUG= R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/e2ee86b3f7ad371346f5f99d4d207080e1e22818

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -81 lines)			Patch
M	runtime/lib/typed_data_patch.dart	View	14 chunks	+0 lines, -28 lines	0 comments	Download
M	runtime/observatory/lib/src/service/object.dart	View	2 chunks	+28 lines, -28 lines	0 comments	Download
M	runtime/observatory/tests/service/get_object_rpc_test.dart	View	8 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/symbols.h	View	1 chunk	+28 lines, -14 lines	0 comments	Download
M	tests/html/html.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 9 (4 generated)

Vyacheslav Egorov (Google)

Does this make new Float64List(10).runtimeType == Float64List work?

3 years, 11 months ago (2017-01-03 09:15:02 UTC) #4

Kevin Millikin (Google)

3 years, 11 months ago (2017-01-05 10:28:29 UTC) #9

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e2ee86b3f7ad371346f5f99d4d207080e1e22818 (presubmit successful).