Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Side by Side Diff: runtime/vm/object.cc

Issue 2610513004: Fix dart:typed_data runtimeType getters. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/observatory/tests/service/get_object_rpc_test.dart ('k') | runtime/vm/symbols.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/object.h" 5 #include "vm/object.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/assembler.h" 9 #include "vm/assembler.h"
10 #include "vm/become.h" 10 #include "vm/become.h"
(...skipping 1492 matching lines...) Expand 10 before | Expand all | Expand 10 after
1503 if (lib.IsNull()) { 1503 if (lib.IsNull()) {
1504 lib = Library::NewLibraryHelper(Symbols::DartTypedData(), true); 1504 lib = Library::NewLibraryHelper(Symbols::DartTypedData(), true);
1505 lib.SetLoadRequested(); 1505 lib.SetLoadRequested();
1506 lib.Register(thread); 1506 lib.Register(thread);
1507 } 1507 }
1508 object_store->set_bootstrap_library(ObjectStore::kTypedData, lib); 1508 object_store->set_bootstrap_library(ObjectStore::kTypedData, lib);
1509 ASSERT(!lib.IsNull()); 1509 ASSERT(!lib.IsNull());
1510 ASSERT(lib.raw() == Library::TypedDataLibrary()); 1510 ASSERT(lib.raw() == Library::TypedDataLibrary());
1511 #define REGISTER_TYPED_DATA_CLASS(clazz) \ 1511 #define REGISTER_TYPED_DATA_CLASS(clazz) \
1512 cls = Class::NewTypedDataClass(kTypedData##clazz##ArrayCid); \ 1512 cls = Class::NewTypedDataClass(kTypedData##clazz##ArrayCid); \
1513 RegisterPrivateClass(cls, Symbols::clazz##List(), lib); 1513 RegisterPrivateClass(cls, Symbols::_##clazz##List(), lib);
1514 1514
1515 DART_CLASS_LIST_TYPED_DATA(REGISTER_TYPED_DATA_CLASS); 1515 DART_CLASS_LIST_TYPED_DATA(REGISTER_TYPED_DATA_CLASS);
1516 #undef REGISTER_TYPED_DATA_CLASS 1516 #undef REGISTER_TYPED_DATA_CLASS
1517 #define REGISTER_TYPED_DATA_VIEW_CLASS(clazz) \ 1517 #define REGISTER_TYPED_DATA_VIEW_CLASS(clazz) \
1518 cls = Class::NewTypedDataViewClass(kTypedData##clazz##ViewCid); \ 1518 cls = Class::NewTypedDataViewClass(kTypedData##clazz##ViewCid); \
1519 RegisterPrivateClass(cls, Symbols::_##clazz##View(), lib); \ 1519 RegisterPrivateClass(cls, Symbols::_##clazz##View(), lib); \
1520 pending_classes.Add(cls); 1520 pending_classes.Add(cls);
1521 1521
1522 CLASS_LIST_TYPED_DATA(REGISTER_TYPED_DATA_VIEW_CLASS); 1522 CLASS_LIST_TYPED_DATA(REGISTER_TYPED_DATA_VIEW_CLASS);
1523 cls = Class::NewTypedDataViewClass(kByteDataViewCid); 1523 cls = Class::NewTypedDataViewClass(kByteDataViewCid);
(...skipping 21391 matching lines...) Expand 10 before | Expand all | Expand 10 after
22915 return UserTag::null(); 22915 return UserTag::null();
22916 } 22916 }
22917 22917
22918 22918
22919 const char* UserTag::ToCString() const { 22919 const char* UserTag::ToCString() const {
22920 const String& tag_label = String::Handle(label()); 22920 const String& tag_label = String::Handle(label());
22921 return tag_label.ToCString(); 22921 return tag_label.ToCString();
22922 } 22922 }
22923 22923
22924 } // namespace dart 22924 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/observatory/tests/service/get_object_rpc_test.dart ('k') | runtime/vm/symbols.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698