[iOS] Correctly reload Sync Encryption settings screen on sync changes.

[iOS] Correctly reload Sync Encryption settings screen on sync changes.

Sync Encryption screen now listens to sync changes and reloads itself
when necessary. This ensures modifications to the passphrase (done by
the Sync Encryption Passphrase screen) are reflected in the UI.

BUG=678609
Review-Url: https://codereview.chromium.org/2610403003
Cr-Commit-Position: refs/heads/master@{#441927}
Committed: https://chromium.googlesource.com/chromium/src/+/e97a0d3d3c1d8f6ed0d5597f9a4f595a9b057b2e

[bzanotti, 2017-01-06 10:38:16]

bzanotti@chromium.org changed reviewers:
+ lpromero@chromium.org

[bzanotti, 2017-01-06 10:38:16]

Please take a look.

[lpromero, 2017-01-06 11:01:07]

https://codereview.chromium.org/2610403003/diff/1/ios/chrome/browser/ui/setti...
File
ios/chrome/browser/ui/settings/sync_encryption_collection_view_controller.mm
(right):

https://codereview.chromium.org/2610403003/diff/1/ios/chrome/browser/ui/setti...
ios/chrome/browser/ui/settings/sync_encryption_collection_view_controller.mm:73:
_syncObserver.reset(new SyncObserverBridge(self, syncService));
Use MakeUnique instead of new.

[lpromero, 2017-01-06 11:01:13]

lgtm

[bzanotti, 2017-01-06 12:41:26]

https://codereview.chromium.org/2610403003/diff/1/ios/chrome/browser/ui/setti...
File
ios/chrome/browser/ui/settings/sync_encryption_collection_view_controller.mm
(right):

https://codereview.chromium.org/2610403003/diff/1/ios/chrome/browser/ui/setti...
ios/chrome/browser/ui/settings/sync_encryption_collection_view_controller.mm:73:
_syncObserver.reset(new SyncObserverBridge(self, syncService));
On 2017/01/06 11:01:07, lpromero wrote:
> Use MakeUnique instead of new.

Done.

[bzanotti, 2017-01-06 12:41:29]

The CQ bit was checked by bzanotti@chromium.org

[bzanotti, 2017-01-06 12:41:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2610403003/#ps20001
(title: "Use MakeUnique with std::unique_ptr")

[commit-bot: I haz the power, 2017-01-06 12:41:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 12:53:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483706489140070,
"parent_rev": "9abd41a856d0d6ecf1f220181ffadac528290668", "commit_rev":
"e97a0d3d3c1d8f6ed0d5597f9a4f595a9b057b2e"}

[commit-bot: I haz the power, 2017-01-06 12:53:35]

Description was changed from

==========
[iOS] Correctly reload Sync Encryption settings screen on sync changes.

Sync Encryption screen now listens to sync changes and reloads itself
when necessary. This ensures modifications to the passphrase (done by
the Sync Encryption Passphrase screen) are reflected in the UI.

BUG=678609
==========

to

==========
[iOS] Correctly reload Sync Encryption settings screen on sync changes.

Sync Encryption screen now listens to sync changes and reloads itself
when necessary. This ensures modifications to the passphrase (done by
the Sync Encryption Passphrase screen) are reflected in the UI.

BUG=678609

Review-Url: https://codereview.chromium.org/2610403003
Cr-Commit-Position: refs/heads/master@{#441927}
Committed:
https://chromium.googlesource.com/chromium/src/+/e97a0d3d3c1d8f6ed0d5597f9a4f...
==========

[commit-bot: I haz the power, 2017-01-06 12:53:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e97a0d3d3c1d8f6ed0d5597f9a4f...