Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: tools/testrunner/local/statusfile.py

Issue 2610353002: [test] Presumbit check against missing tests in status files (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/test262/test262.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testrunner/local/statusfile.py
diff --git a/tools/testrunner/local/statusfile.py b/tools/testrunner/local/statusfile.py
index 091754043bc048844d9ee95cdc9d09a36b0db337..940a574b1c7ce76a5a7782d8c347cc621836b1e1 100644
--- a/tools/testrunner/local/statusfile.py
+++ b/tools/testrunner/local/statusfile.py
@@ -255,6 +255,17 @@ def PresubmitCheck(path):
"Suite name prefix must not be used in rule keys")
_assert(not rule.endswith('.js'),
".js extension must not be used in rule keys.")
+ if 'test262' in path and '*' not in rule:
Michael Achenbach 2017/01/06 09:13:39 Could you make this more generic for all the suite
Dan Ehrenberg 2017/01/06 09:48:31 Done.
+ _assert(os.path.exists(os.path.join(os.path.dirname(path),
+ "data", "test", rule + ".js")) or
+ os.path.exists(os.path.join(os.path.dirname(path),
+ "local-tests", "test",
+ rule + ".js")),
+ "missing file for test262 test %s" % rule)
+ if 'mjsunit' in path and '*' not in rule:
+ _assert(os.path.exists(os.path.join(os.path.dirname(path),
+ rule + ".js")),
+ "missing file for mjsunit test %s" % rule)
return status["success"]
except Exception as e:
print e
« no previous file with comments | « test/test262/test262.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698