Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: tools/testrunner/local/statusfile.py

Issue 2610353002: [test] Presumbit check against missing tests in status files (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/test262/test262.status ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 the V8 project authors. All rights reserved. 1 # Copyright 2012 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 _assert(len(section) == 2, "Section list must have exactly 2 entries") 248 _assert(len(section) == 2, "Section list must have exactly 2 entries")
249 section = section[1] 249 section = section[1]
250 _assert(type(section) == dict, 250 _assert(type(section) == dict,
251 "Second entry of section must be a dictionary") 251 "Second entry of section must be a dictionary")
252 for rule in section: 252 for rule in section:
253 _assert(type(rule) == str, "Rule key must be a string") 253 _assert(type(rule) == str, "Rule key must be a string")
254 _assert(not rule.startswith(root_prefix), 254 _assert(not rule.startswith(root_prefix),
255 "Suite name prefix must not be used in rule keys") 255 "Suite name prefix must not be used in rule keys")
256 _assert(not rule.endswith('.js'), 256 _assert(not rule.endswith('.js'),
257 ".js extension must not be used in rule keys.") 257 ".js extension must not be used in rule keys.")
258 if 'test262' in path and '*' not in rule:
Michael Achenbach 2017/01/06 09:13:39 Could you make this more generic for all the suite
Dan Ehrenberg 2017/01/06 09:48:31 Done.
259 _assert(os.path.exists(os.path.join(os.path.dirname(path),
260 "data", "test", rule + ".js")) or
261 os.path.exists(os.path.join(os.path.dirname(path),
262 "local-tests", "test",
263 rule + ".js")),
264 "missing file for test262 test %s" % rule)
265 if 'mjsunit' in path and '*' not in rule:
266 _assert(os.path.exists(os.path.join(os.path.dirname(path),
267 rule + ".js")),
268 "missing file for mjsunit test %s" % rule)
258 return status["success"] 269 return status["success"]
259 except Exception as e: 270 except Exception as e:
260 print e 271 print e
261 return False 272 return False
OLDNEW
« no previous file with comments | « test/test262/test262.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698