Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issue 2610323004: Remove skia::DrawToNativeContext() (Closed)

Created:
3 years, 11 months ago by f(malita)
Modified:
3 years, 11 months ago
CC:
chromium-reviews, jam, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove skia::DrawToNativeContext() It has only one client. Inline the implementation (and simplify, as the optional src_rect param is always present). BUG=675977 R=reed@google.com,robertphillips@chromium.org TBR=danakj@chromium.org Review-Url: https://codereview.chromium.org/2610323004 Cr-Commit-Position: refs/heads/master@{#442030} Committed: https://chromium.googlesource.com/chromium/src/+/eb91daf3dc965936e6795cecc6debe1efa78d320

Patch Set 1 #

Patch Set 2 : missing header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -28 lines) Patch
M content/browser/compositor/software_output_device_win.cc View 1 3 chunks +11 lines, -3 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M skia/ext/platform_canvas.h View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
f(malita)
3 years, 11 months ago (2017-01-06 02:14:45 UTC) #9
reed1
lgtm
3 years, 11 months ago (2017-01-06 14:50:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610323004/20001
3 years, 11 months ago (2017-01-06 20:24:52 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 20:32:01 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/eb91daf3dc965936e6795cecc6de...

Powered by Google App Engine
This is Rietveld 408576698