Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2610273002: Make isolate cache resilient to unexpectedly deleted items. (Closed)

Created:
3 years, 11 months ago by Vadim Sh.
Modified:
3 years, 11 months ago
Reviewers:
agable
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Make isolate cache resilient to unexpectedly deleted items. It seems to be a regression. Add a test. R=agable@chromium.org BUG=678396 Review-Url: https://codereview.chromium.org/2610273002 Committed: https://github.com/luci/luci-py/commit/ae56b3a60ca775afa9e049fa32470a15ef2e1c13

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -13 lines) Patch
M client/isolateserver.py View 6 chunks +20 lines, -10 lines 0 comments Download
M client/tests/isolateserver_test.py View 4 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Vadim Sh.
3 years, 11 months ago (2017-01-05 00:04:51 UTC) #1
agable
LGTM. Not familiar with the code, but code makes sense and test looks good.
3 years, 11 months ago (2017-01-05 00:07:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610273002/1
3 years, 11 months ago (2017-01-05 00:09:18 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 00:42:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/ae56b3a60ca775afa9e049fa32470a15ef2e1c13

Powered by Google App Engine
This is Rietveld 408576698