Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Issue 2610233002: Check ExecutionContext before calling isContextDestroyed() (Closed)

Created:
3 years, 11 months ago by jrummell
Modified:
3 years, 11 months ago
CC:
chromium-reviews, blink-reviews, tommyw+watchlist_chromium.org, mcasas+watch+mediastream_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check ExecutionContext before calling isContextDestroyed() BUG=677878 TEST=mediastream layouttests pass Committed: https://crrev.com/f6a0f4b7f8abe662390f61e1d5133a0894bb6080 Cr-Commit-Position: refs/heads/master@{#441595}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/modules/mediastream/MediaStream.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
jrummell
PTAL. See bug for crash details.
3 years, 11 months ago (2017-01-04 22:55:40 UTC) #4
haraken
LGTM
3 years, 11 months ago (2017-01-04 23:43:17 UTC) #5
tommi (sloooow) - chröme
lgtm
3 years, 11 months ago (2017-01-05 06:05:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610233002/1
3 years, 11 months ago (2017-01-05 06:05:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-05 06:10:42 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f6a0f4b7f8abe662390f61e1d5133a0894bb6080 Cr-Commit-Position: refs/heads/master@{#441595}
3 years, 11 months ago (2017-01-05 06:13:02 UTC) #15
sof
3 years, 11 months ago (2017-01-05 07:25:24 UTC) #17
Message was sent while issue was closed.
Switching MediaStream to be a ContextClient would be a workable alternative.

Powered by Google App Engine
This is Rietveld 408576698