Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2610203002: Removes aura::Window::set_user_data() (Closed)

Created:
3 years, 11 months ago by sky
Modified:
3 years, 11 months ago
CC:
chromium-reviews, kalyank, sadrul, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removes aura::Window::set_user_data() It overlaps with properties, and properties add type safety. BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/8e37fbee0ce0215ceef931e2cbb4aee343d10523 Cr-Commit-Position: refs/heads/master@{#441474}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M ui/aura/window.h View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/aura/window.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 4 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
sky
3 years, 11 months ago (2017-01-04 21:40:05 UTC) #5
Ben Goodger (Google)
lgtm
3 years, 11 months ago (2017-01-04 21:40:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610203002/1
3 years, 11 months ago (2017-01-04 21:42:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 21:46:32 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 21:50:44 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e37fbee0ce0215ceef931e2cbb4aee343d10523
Cr-Commit-Position: refs/heads/master@{#441474}

Powered by Google App Engine
This is Rietveld 408576698