Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2610173004: Add ability to enqueue SharedFunctionInfos so they can run on bg threads (Closed)

Created:
3 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 11 months ago
Reviewers:
vogelheim, marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add ability to enqueue SharedFunctionInfos so they can run on bg threads If this is possible at all, we need to at least do the first step (prepare to parse). BUG=v8:5215 R=vogelheim@chromium.org,marja@chromium.org Review-Url: https://codereview.chromium.org/2610173004 Cr-Commit-Position: refs/heads/master@{#42124} Committed: https://chromium.googlesource.com/v8/v8/+/65537684b6c07b0cb7aee94b06b6e582214f992f

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M src/compiler-dispatcher/compiler-dispatcher.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
jochen (gone - plz use gerrit)
3 years, 11 months ago (2017-01-05 16:13:18 UTC) #1
vogelheim
lgtm https://codereview.chromium.org/2610173004/diff/1/src/compiler-dispatcher/compiler-dispatcher.h File src/compiler-dispatcher/compiler-dispatcher.h (right): https://codereview.chromium.org/2610173004/diff/1/src/compiler-dispatcher/compiler-dispatcher.h#newcode74 src/compiler-dispatcher/compiler-dispatcher.h:74: // Like Enqueue, but also does advances the ...
3 years, 11 months ago (2017-01-05 16:43:33 UTC) #6
marja
lgtm
3 years, 11 months ago (2017-01-05 18:33:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610173004/20001
3 years, 11 months ago (2017-01-09 08:23:40 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 08:52:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/65537684b6c07b0cb7aee94b06b6e582214...

Powered by Google App Engine
This is Rietveld 408576698