Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2610173002: Fix AccountManagerHelper assert access from FRE. (Closed)

Created:
3 years, 11 months ago by Ted C
Modified:
3 years, 11 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix AccountManagerHelper assert access from FRE. FRE was made to lazily load the libraries, but it attempts to access the AccountManagerHelper before it has been fully initialized. To avoid this, use ChromeBrowserInitializer to the pre native initialization early, which will call into: ProcessInitializationHandler#handlePreNativeInitialization, which does AccountManagerHelper.initializeAccountManagerHelper. BUG= Committed: https://crrev.com/bcf1404d6a55ecd90d06c0fd602116a312a8ceaf Cr-Commit-Position: refs/heads/master@{#441419}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Ted C
PTAL This can be removed entirely when you land your AsyncInitializationActivity bit, but better to ...
3 years, 11 months ago (2017-01-04 17:59:25 UTC) #2
Alexei Svitkine (slow)
lgtm
3 years, 11 months ago (2017-01-04 18:07:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610173002/1
3 years, 11 months ago (2017-01-04 18:09:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 18:49:27 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 18:51:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcf1404d6a55ecd90d06c0fd602116a312a8ceaf
Cr-Commit-Position: refs/heads/master@{#441419}

Powered by Google App Engine
This is Rietveld 408576698