Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.h

Issue 2610063006: Create TaskAttributionTiming PerformanceEntry for attribution in PerformanceLongTaskTiming. Move cu… (Closed)
Patch Set: update copyright year Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.h
diff --git a/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.h b/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.h
index 2784365cf2bf85fd2976f7f6d6f23cbb00f65dc5..ee87d0f12b0efadeeb196a4f57ea0701704363f8 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.h
+++ b/third_party/WebKit/Source/core/timing/PerformanceLongTaskTiming.h
@@ -12,6 +12,9 @@
namespace blink {
+class TaskAttributionTiming;
+using TaskAttributionVector = HeapVector<Member<TaskAttributionTiming>>;
+
class PerformanceLongTaskTiming final : public PerformanceEntry {
DEFINE_WRAPPERTYPEINFO();
@@ -21,15 +24,9 @@ class PerformanceLongTaskTiming final : public PerformanceEntry {
String name,
String culpritFrameSrc,
String culpritFrameId,
- String culpritFrameName) {
- return new PerformanceLongTaskTiming(startTime, endTime, name,
- culpritFrameSrc, culpritFrameId,
- culpritFrameName);
- }
+ String culpritFrameName);
- String culpritFrameSrc() const;
- String culpritFrameId() const;
- String culpritFrameName() const;
+ TaskAttributionVector attribution() const;
DECLARE_VIRTUAL_TRACE();
@@ -42,9 +39,7 @@ class PerformanceLongTaskTiming final : public PerformanceEntry {
String culpritFrameName);
~PerformanceLongTaskTiming() override;
- String m_culpritFrameSrc;
- String m_culpritFrameId;
- String m_culpritFrameName;
+ TaskAttributionVector m_attribution;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698