Create TaskAttributionTiming PerformanceEntry for attribution in PerformanceLongTaskTiming. Move cu…

third_party/WebKit/Source/core/timing/PerformanceBase.cpp

Index: third_party/WebKit/Source/core/timing/PerformanceBase.cpp
diff --git a/third_party/WebKit/Source/core/timing/PerformanceBase.cpp b/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
index aa49b288243b451cf35a4f9024895baed6f96337..75089a33697c37905e1fd8b3aaf7b254f5e9bdfb 100644
--- a/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
+++ b/third_party/WebKit/Source/core/timing/PerformanceBase.cpp
@@ -135,9 +135,12 @@ PerformanceEntryVector PerformanceBase::getEntriesByType(
   switch (type) {
     case PerformanceEntry::Invalid:
       return entries;
+    // Unsupported for LongTask, TaskAttribution.
+    // Per the spec, these entries can only be accessed via
+    // Performance Observer. No separate buffer is maintained.
     case PerformanceEntry::LongTask:

[tdresser, 2017/01/05 13:34:14]

I'd be tempted to stick these cases at the bottom of the switch, and immediately
break, instead of having separate returns, as it's kind of nice to have a single
return statement.

This way is fine too though.

[panicker, 2017/01/05 20:56:49]

Done.

-      // Unsupported for LongTask. Per the spec, Long task entries can only be
-      // accessed via Performance Observer. No separate buffer is maintained.
+      return entries;
+    case PerformanceEntry::TaskAttribution:
       return entries;
     case PerformanceEntry::Resource:
       for (const auto& resource : m_resourceTimingBuffer)