Chromium Code Reviews| Index: third_party/WebKit/LayoutTests/fast/performance/longtasktiming.html |
| diff --git a/third_party/WebKit/LayoutTests/fast/performance/longtasktiming.html b/third_party/WebKit/LayoutTests/fast/performance/longtasktiming.html |
| index cd5f0453b1d4b345660afa0f71766cb906ec8616..bb515f441f1f92dc307dcef1334a3f09b014bd0d 100644 |
| --- a/third_party/WebKit/LayoutTests/fast/performance/longtasktiming.html |
| +++ b/third_party/WebKit/LayoutTests/fast/performance/longtasktiming.html |
| @@ -7,17 +7,27 @@ async_test(function (t) { |
| var observer = new PerformanceObserver( |
| t.step_func(function (entryList) { |
| var entries = entryList.getEntries(); |
| - /* TODO(panicker): Update after fixing http://crbug.com/651461 */ |
| - for (var i = 0; i < entries.length; i++) { |
| - assert_equals(entries[i].entryType, "longtask", |
| - "entryType expected to be: longtask"); |
| - assert_equals(entries[i].name, "same-origin-self", |
| - "name expected to be: same-origin-self"); |
| - assert_greater_than(entries[i].duration, 50, |
| - "duration expected to be greater than 50ms threshold"); |
| - assert_equals(entries[i].startTime, Math.floor(entries[i].startTime), |
| - "startTime expected to have 1 miilisecond granularity"); |
| - } |
| + assert_equals(entries.length, 1, |
| + "Exactly one entry is expected."); |
| + var longtask = entries[0]; |
| + assert_equals(longtask.entryType, "longtask", |
| + "entryType expected to be: longtask"); |
| + assert_equals(longtask.name, "same-origin-self", |
| + "name expected to be: same-origin-self"); |
| + assert_greater_than(longtask.duration, 50, |
| + "duration expected to be greater than 50ms threshold"); |
| + assert_equals(longtask.startTime, Math.floor(longtask.startTime), |
| + "startTime expected to have 1 miilisecond granularity"); |
|
tdresser
2017/01/05 13:34:14
millisecond
panicker
2017/01/05 20:56:49
Done.
|
| + |
| + // Assert the TaskAttributionTiming entry in attribution |
|
tdresser
2017/01/05 13:34:14
Nit: I think comments are supposed to always end i
panicker
2017/01/05 20:56:49
Done.
|
| + assert_equals(longtask.attribution.length, 1, |
| + "Exactly one attribution entry is expected"); |
| + var attribution = longtask.attribution[0]; |
| + assert_equals(attribution.entryType, "taskattribution"); |
| + assert_equals(attribution.name, "frame"); |
| + assert_equals(attribution.duration, 0); |
| + assert_equals(attribution.startTime, 0); |
| + |
| observer.disconnect(); |
| t.done(); |
| }) |