Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2610033003: [Mac] Prevent omnibox text bg from drawing over decoration, focus ring.

Created:
3 years, 11 months ago by shrike
Modified:
3 years, 11 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Mac] Prevent omnibox text bg from drawing over decoration, focus ring. The AutocompleteTextFieldEditor draws a background, apparently even when you call setDrawsBackground:NO (at least during editing). Because of the 1pt spacing set by UX between the security decoration border and the start of omnibox text, this background started drawing into the decoration's hover rect. On the right edge it drew into the edge of the focus ring. This cl prevents the AutocompleteTetFieldEditor from drawing a background, relying instead on the background drawn by the textfield's cell. It also changes decorations to be drawn after the cell's interior, to prevent the background overlap when not editing. R=avi@chromium.org BUG=669870, 672518 Review-Url: https://codereview.chromium.org/2562863002 Cr-Commit-Position: refs/heads/master@{#437596} (cherry picked from commit 55c13aa9610ea5e5dc91f3d3b21c5cc42d05ff5c)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -8 lines) Patch
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm View 2 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.mm View 1 chunk +14 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698