[Mac] Prevent omnibox text bg from drawing over decoration, focus ring.

[Mac] Prevent omnibox text bg from drawing over  decoration, focus ring.

The AutocompleteTextFieldEditor draws a background, apparently even when
you call setDrawsBackground:NO (at least during editing). Because of the
1pt spacing set by UX between the security decoration border and the
start of omnibox text, this background started drawing into the
decoration's hover rect. On the right edge it drew into the edge of the
focus ring.

This cl	prevents the AutocompleteTetFieldEditor	from drawing a
background, relying instead on the background drawn by the textfield's
cell. It also changes decorations to be drawn after the cell's interior,
to prevent the background overlap when not editing.

R=avi@chromium.org
BUG=669870, 672518
Committed: https://crrev.com/55c13aa9610ea5e5dc91f3d3b21c5cc42d05ff5c
Cr-Commit-Position: refs/heads/master@{#437596}

[shrike, 2016-12-09 00:04:59]

PTAL

[Avi (use Gerrit), 2016-12-09 15:52:21]

LGTM

[shrike, 2016-12-09 18:12:13]

The CQ bit was checked by shrike@chromium.org

[commit-bot: I haz the power, 2016-12-09 18:13:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 18:47:05]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481307133233440, "parent_rev":
"203f8fc07f0ca77584a4a0db27e291daca9acaa1", "commit_rev":
"81986847a4173f5b3bbd9c49cd91619a9b66b7f5"}

[commit-bot: I haz the power, 2016-12-09 18:47:36]

Description was changed from

==========
[Mac] Prevent omnibox text bg from drawing over  decoration, focus ring.

The AutocompleteTextFieldEditor draws a background, apparently even when
you call setDrawsBackground:NO (at least during editing). Because of the
1pt spacing set by UX between the security decoration border and the
start of omnibox text, this background started drawing into the
decoration's hover rect. On the right edge it drew into the edge of the
focus ring.

This cl	prevents the AutocompleteTetFieldEditor	from drawing a
background, relying instead on the background drawn by the textfield's
cell. It also changes decorations to be drawn after the cell's interior,
to prevent the background overlap when not editing.

R=avi@chromium.org
BUG=669870,672518
==========

to

==========
[Mac] Prevent omnibox text bg from drawing over  decoration, focus ring.

The AutocompleteTextFieldEditor draws a background, apparently even when
you call setDrawsBackground:NO (at least during editing). Because of the
1pt spacing set by UX between the security decoration border and the
start of omnibox text, this background started drawing into the
decoration's hover rect. On the right edge it drew into the edge of the
focus ring.

This cl	prevents the AutocompleteTetFieldEditor	from drawing a
background, relying instead on the background drawn by the textfield's
cell. It also changes decorations to be drawn after the cell's interior,
to prevent the background overlap when not editing.

R=avi@chromium.org
BUG=669870,672518

Review-Url: https://codereview.chromium.org/2562863002
==========

[commit-bot: I haz the power, 2016-12-09 18:47:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-12 14:36:32]

Description was changed from

==========
[Mac] Prevent omnibox text bg from drawing over  decoration, focus ring.

The AutocompleteTextFieldEditor draws a background, apparently even when
you call setDrawsBackground:NO (at least during editing). Because of the
1pt spacing set by UX between the security decoration border and the
start of omnibox text, this background started drawing into the
decoration's hover rect. On the right edge it drew into the edge of the
focus ring.

This cl	prevents the AutocompleteTetFieldEditor	from drawing a
background, relying instead on the background drawn by the textfield's
cell. It also changes decorations to be drawn after the cell's interior,
to prevent the background overlap when not editing.

R=avi@chromium.org
BUG=669870,672518

Review-Url: https://codereview.chromium.org/2562863002
==========

to

==========
[Mac] Prevent omnibox text bg from drawing over  decoration, focus ring.

The AutocompleteTextFieldEditor draws a background, apparently even when
you call setDrawsBackground:NO (at least during editing). Because of the
1pt spacing set by UX between the security decoration border and the
start of omnibox text, this background started drawing into the
decoration's hover rect. On the right edge it drew into the edge of the
focus ring.

This cl	prevents the AutocompleteTetFieldEditor	from drawing a
background, relying instead on the background drawn by the textfield's
cell. It also changes decorations to be drawn after the cell's interior,
to prevent the background overlap when not editing.

R=avi@chromium.org
BUG=669870,672518

Committed: https://crrev.com/55c13aa9610ea5e5dc91f3d3b21c5cc42d05ff5c
Cr-Commit-Position: refs/heads/master@{#437596}
==========

[commit-bot: I haz the power, 2016-12-12 14:36:33]

Patchset 1 (id:??) landed as
https://crrev.com/55c13aa9610ea5e5dc91f3d3b21c5cc42d05ff5c
Cr-Commit-Position: refs/heads/master@{#437596}