Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2610003003:
Add Incognito test case (Closed)
|
Created:
3 years, 11 months ago by Robert Ogden Modified:
3 years, 11 months ago CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd Incognito test case
BUG=
Committed: https://crrev.com/52886f4ff32ac773507487fd7f53f9b59748f687
Cr-Commit-Position: refs/heads/master@{#441488}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fix copyright #Messages
Total messages: 18 (9 generated)
Description was changed from ========== Add Incognito test case BUG= ========== to ========== Add Incognito test case BUG= ==========
robertogden@chromium.org changed reviewers: + bustamante@chromium.org, sclittle@chromium.org
lgtm
robertogden@chromium.org changed reviewers: - sclittle@chromium.org
robertogden@chromium.org changed reviewers: + ryansturm@chromium.org
Add Ryan instead of Scott for committer LGTM
lgtm % nit https://codereview.chromium.org/2610003003/diff/1/tools/chrome_proxy/webdrive... File tools/chrome_proxy/webdriver/incognito.py (right): https://codereview.chromium.org/2610003003/diff/1/tools/chrome_proxy/webdrive... tools/chrome_proxy/webdriver/incognito.py:1: # Copyright 2016 The Chromium Authors. All rights reserved. s/2016/2017/
https://codereview.chromium.org/2610003003/diff/1/tools/chrome_proxy/webdrive... File tools/chrome_proxy/webdriver/incognito.py (right): https://codereview.chromium.org/2610003003/diff/1/tools/chrome_proxy/webdrive... tools/chrome_proxy/webdriver/incognito.py:1: # Copyright 2016 The Chromium Authors. All rights reserved. On 2017/01/04 21:24:33, Ryan Sturm wrote: > s/2016/2017/ Done.
The CQ bit was checked by robertogden@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ryansturm@chromium.org, bustamante@chromium.org Link to the patchset: https://codereview.chromium.org/2610003003/#ps20001 (title: "Fix copyright")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483567896402960,
"parent_rev": "960bdd5d419ddce259ee4b3cd8816f22be0cf2ce", "commit_rev":
"1ebc19fa13d3e4280fa58ca739db0678d8811859"}
Message was sent while issue was closed.
Description was changed from ========== Add Incognito test case BUG= ========== to ========== Add Incognito test case BUG= Review-Url: https://codereview.chromium.org/2610003003 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add Incognito test case BUG= Review-Url: https://codereview.chromium.org/2610003003 ========== to ========== Add Incognito test case BUG= Committed: https://crrev.com/52886f4ff32ac773507487fd7f53f9b59748f687 Cr-Commit-Position: refs/heads/master@{#441488} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/52886f4ff32ac773507487fd7f53f9b59748f687 Cr-Commit-Position: refs/heads/master@{#441488}
Message was sent while issue was closed.
lgtm |
