Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 2610003002: Remove skia::SupportsPlatformPaint() (Closed)

Created:
3 years, 11 months ago by f(malita)
Modified:
3 years, 11 months ago
Reviewers:
reed1, Evan Stade
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove skia::SupportsPlatformPaint() It is equivalent to checking the result of GetNativeDrawingContext(), so do that instead, in NativeThemeWin::Paint(). Also remove an unused param of NativeThemeWin::PaintIndirect(). BUG=675977 R=reed@google.com Committed: https://crrev.com/233c886dc8f37fe7ba3b53f3c7e5e431cb150ff6 Cr-Commit-Position: refs/heads/master@{#441388}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M skia/ext/platform_canvas.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M skia/ext/platform_canvas.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ui/native_theme/native_theme_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/native_theme/native_theme_win.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
f(malita)
3 years, 11 months ago (2017-01-03 21:14:22 UTC) #3
reed1
lgtm
3 years, 11 months ago (2017-01-03 21:21:40 UTC) #4
reed1
lgtm
3 years, 11 months ago (2017-01-03 21:22:20 UTC) #5
f(malita)
+estade@ for ui/native_theme/native_theme_win owner.
3 years, 11 months ago (2017-01-04 14:58:15 UTC) #12
Evan Stade
lgtm
3 years, 11 months ago (2017-01-04 15:47:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2610003002/20001
3 years, 11 months ago (2017-01-04 16:14:02 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 16:30:08 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 16:32:10 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/233c886dc8f37fe7ba3b53f3c7e5e431cb150ff6
Cr-Commit-Position: refs/heads/master@{#441388}

Powered by Google App Engine
This is Rietveld 408576698