Fix empty push bug in Array.push

Fix empty push bug in Array.push

BUG=chromium:670981
LOG=N
R=ishell@chromium.org

Review-Url: https://codereview.chromium.org/2609973002
Cr-Commit-Position: refs/heads/master@{#42064}
Committed: https://chromium.googlesource.com/v8/v8/+/fcffcba72581ea338e13f79f57df758449093179

[danno, 2017-01-03 20:13:06]

danno@chromium.org changed reviewers:
+ ishell@chromium.org

[danno, 2017-01-03 20:13:06]

PTAL

[danno, 2017-01-03 20:13:23]

Description was changed from

==========
Fix empty push bug in Array.push

BUG=chromium:670981
==========

to

==========
Fix empty push bug in Array.push

BUG=chromium:670981
LOG=N
R=ishell@chromium.org
==========

[Igor Sheludko, 2017-01-04 07:45:26]

lgtm but please also add this assert to CodeStubArguments::AtIndex():
  CSA_ASSERT(assembler_, assembler_->UintPtrLessThan(index, GetLength()));

[danno, 2017-01-04 10:21:51]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 10:21:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 10:24:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 10:24:03]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/18581)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/18551)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/14998)

[danno, 2017-01-04 10:27:27]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 10:27:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 10:52:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 10:52:31]

Dry run: This issue passed the CQ dry run.

[danno, 2017-01-04 10:55:45]

The CQ bit was checked by danno@chromium.org

[danno, 2017-01-04 10:55:46]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2609973002/#ps60001
(title: "Fix builds")

[commit-bot: I haz the power, 2017-01-04 10:55:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 10:57:27]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483527345847080,
"parent_rev": "2a60fd49db2d787f0dd6a7a731485011ec89d35f", "commit_rev":
"fcffcba72581ea338e13f79f57df758449093179"}

[commit-bot: I haz the power, 2017-01-04 10:57:31]

Description was changed from

==========
Fix empty push bug in Array.push

BUG=chromium:670981
LOG=N
R=ishell@chromium.org
==========

to

==========
Fix empty push bug in Array.push

BUG=chromium:670981
LOG=N
R=ishell@chromium.org

Review-Url: https://codereview.chromium.org/2609973002
Cr-Commit-Position: refs/heads/master@{#42064}
Committed:
https://chromium.googlesource.com/v8/v8/+/fcffcba72581ea338e13f79f57df7584490...
==========

[commit-bot: I haz the power, 2017-01-04 10:57:32]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/fcffcba72581ea338e13f79f57df7584490...