Gtk3: Add support for Gtk3.20 themes

Gtk3: Add support for Gtk3.20 themes

Gtk3.20 added CSS names and changed a bunch of widget's classes to be
names instead.  This CL adds a runtime check for Gtk3.20 and uses
names for newer versions, and classes otherwise.  Unfortunately we
must load the symbol for setting the object name dynamically since we
still need to support Gtk3.10 (on Trusty).

BUG=132847
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2609943005
Cr-Commit-Position: refs/heads/master@{#441762}
Committed: https://chromium.googlesource.com/chromium/src/+/7563580907ed85a7ec511bedc8a293ab5951cf03

[Tom (Use chromium acct), 2017-01-05 03:04:03]

Patchset #1 (id:1) has been deleted

[Elliot Glaysher, 2017-01-05 18:14:46]

lgtm

https://codereview.chromium.org/2609943005/diff/20001/chrome/browser/ui/libgt...
File chrome/browser/ui/libgtkui/gtk_util.cc (right):

https://codereview.chromium.org/2609943005/diff/20001/chrome/browser/ui/libgt...
chrome/browser/ui/libgtkui/gtk_util.cc:263:
"gtk_widget_path_iter_set_object_name"));
You probably want this inside the version checked if block.

[Tom (Use chromium acct), 2017-01-05 20:27:05]

https://codereview.chromium.org/2609943005/diff/20001/chrome/browser/ui/libgt...
File chrome/browser/ui/libgtkui/gtk_util.cc (right):

https://codereview.chromium.org/2609943005/diff/20001/chrome/browser/ui/libgt...
chrome/browser/ui/libgtkui/gtk_util.cc:263:
"gtk_widget_path_iter_set_object_name"));
On 2017/01/05 18:14:45, Elliot Glaysher wrote:
> You probably want this inside the version checked if block.

Done.

[Tom (Use chromium acct), 2017-01-05 20:27:08]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2017-01-05 20:27:08]

The patchset sent to the CQ was uploaded after l-g-t-m from erg@chromium.org
Link to the patchset: https://codereview.chromium.org/2609943005/#ps40001
(title: "Move var in scope")

[commit-bot: I haz the power, 2017-01-05 20:27:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 21:34:51]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483648028245570,
"parent_rev": "eec5f76832b767aea7ef2990cf738df292c0f8fc", "commit_rev":
"7563580907ed85a7ec511bedc8a293ab5951cf03"}

[commit-bot: I haz the power, 2017-01-05 21:35:18]

Description was changed from

==========
Gtk3: Add support for Gtk3.20 themes

Gtk3.20 added CSS names and changed a bunch of widget's classes to be
names instead.  This CL adds a runtime check for Gtk3.20 and uses
names for newer versions, and classes otherwise.  Unfortunately we
must load the symbol for setting the object name dynamically since we
still need to support Gtk3.10 (on Trusty).

BUG=132847
R=erg@chromium.org
==========

to

==========
Gtk3: Add support for Gtk3.20 themes

Gtk3.20 added CSS names and changed a bunch of widget's classes to be
names instead.  This CL adds a runtime check for Gtk3.20 and uses
names for newer versions, and classes otherwise.  Unfortunately we
must load the symbol for setting the object name dynamically since we
still need to support Gtk3.10 (on Trusty).

BUG=132847
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2609943005
Cr-Commit-Position: refs/heads/master@{#441762}
Committed:
https://chromium.googlesource.com/chromium/src/+/7563580907ed85a7ec511bedc8a2...
==========

[commit-bot: I haz the power, 2017-01-05 21:35:19]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7563580907ed85a7ec511bedc8a2...