MacViews: Don't click views::Link on pressing Return key.

MacViews: Don't click views::Link on pressing Return key.

On Mac, the Return key is used to perform the default action associated with a
dialog even when a control is focused. Modify Link::OnKeyPressed and
Link::SkipDefaultKeyEventProcessing to respect the value of
PlatformStyle::kReturnClicksFocusedControl so that focused links are not clicked
on pressing Return. Instead on MacViews, Return is treated as an accelerator and
performs the default action.

BUG=607430
TEST=On Mac, enable chrome://flags/#secondary-ui-md. Open the Bookmark Bubble.
Enable Full Keyboard Access (Ctrl+F7). Ensure no user is signed onto Chromium.
Focus the "sign in to Chromium." link. Press Return key. Ensure the link is not
clicked. Instead, the default action is performed (associated with the Done
button).

Review-Url: https://codereview.chromium.org/2609943004
Cr-Commit-Position: refs/heads/master@{#441626}
Committed: https://chromium.googlesource.com/chromium/src/+/3da0435e15d762ba56ab91d08f3ccd63efedbeab

[karandeepb, 2017-01-04 03:29:39]

Description was changed from

==========
MacViews: Don't click views::Link on pressing Return key.

On Mac, the Return key is used to perform the default action associated with a
dialog even when a control is focused. Modify Link::OnKeyPressed and
Link::SkipDefaultKeyEventProcessing to respect the value of
PlatformStylek::ClickControlOnReturn so that focused links are not clicked on
pressing Return. Instead on MacViews, Return is treated as an accelerator and
performs the default action.

BUG=607430
TEST=On Mac, enable chrome://flags/#secondary-ui-md. Open the Bookmark Bubble.
Enable Full Keyboard Access(Ctrl+F7). Ensure no user is signed onto Chrome.
==========

to

==========
MacViews: Don't click views::Link on pressing Return key.

On Mac, the Return key is used to perform the default action associated with a
dialog even when a control is focused. Modify Link::OnKeyPressed and
Link::SkipDefaultKeyEventProcessing to respect the value of
PlatformStyle::kClickControlOnReturn so that focused links are not clicked on
pressing Return. Instead on MacViews, Return is treated as an accelerator and
performs the default action.

BUG=607430
TEST=On Mac, enable chrome://flags/#secondary-ui-md. Open the Bookmark Bubble.
Enable Full Keyboard Access (Ctrl+F7). Ensure no user is signed onto Chromium.
Focus the "sign in to Chromium." link. Press Return key. Ensure the link is not
clicked. Instead, the default action is performed (associated with the Done
button).
==========

[karandeepb, 2017-01-04 03:58:08]

Patchset #2 (id:20001) has been deleted

[karandeepb, 2017-01-04 04:01:42]

karandeepb@chromium.org changed reviewers:
+ tapted@chromium.org

[karandeepb, 2017-01-04 04:01:43]

PTAL Trent. This depends on https://codereview.chromium.org/2607923002/.

[karandeepb, 2017-01-04 06:17:15]

Description was changed from

==========
MacViews: Don't click views::Link on pressing Return key.

On Mac, the Return key is used to perform the default action associated with a
dialog even when a control is focused. Modify Link::OnKeyPressed and
Link::SkipDefaultKeyEventProcessing to respect the value of
PlatformStyle::kClickControlOnReturn so that focused links are not clicked on
pressing Return. Instead on MacViews, Return is treated as an accelerator and
performs the default action.

BUG=607430
TEST=On Mac, enable chrome://flags/#secondary-ui-md. Open the Bookmark Bubble.
Enable Full Keyboard Access (Ctrl+F7). Ensure no user is signed onto Chromium.
Focus the "sign in to Chromium." link. Press Return key. Ensure the link is not
clicked. Instead, the default action is performed (associated with the Done
button).
==========

to

==========
MacViews: Don't click views::Link on pressing Return key.

On Mac, the Return key is used to perform the default action associated with a
dialog even when a control is focused. Modify Link::OnKeyPressed and
Link::SkipDefaultKeyEventProcessing to respect the value of
PlatformStyle::kReturnClicksFocusedControl so that focused links are not clicked
on pressing Return. Instead on MacViews, Return is treated as an accelerator and
performs the default action.

BUG=607430
TEST=On Mac, enable chrome://flags/#secondary-ui-md. Open the Bookmark Bubble.
Enable Full Keyboard Access (Ctrl+F7). Ensure no user is signed onto Chromium.
Focus the "sign in to Chromium." link. Press Return key. Ensure the link is not
clicked. Instead, the default action is performed (associated with the Done
button).
==========

[tapted, 2017-01-05 02:26:55]

lgtm

https://codereview.chromium.org/2609943004/diff/60001/ui/views/controls/link.cc
File ui/views/controls/link.cc (right):

https://codereview.chromium.org/2609943004/diff/60001/ui/views/controls/link....
ui/views/controls/link.cc:130: return (event.key_code() == ui::VKEY_SPACE) ||
nit: the parens around this `==` look odd

[karandeepb, 2017-01-05 09:57:23]

The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 09:57:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 10:57:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 10:57:51]

Dry run: This issue passed the CQ dry run.

[karandeepb, 2017-01-05 11:15:32]

The CQ bit was checked by karandeepb@chromium.org

[karandeepb, 2017-01-05 11:15:32]

The patchset sent to the CQ was uploaded after l-g-t-m from tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/2609943004/#ps80001
(title: "Address review.")

[karandeepb, 2017-01-05 11:15:40]

https://codereview.chromium.org/2609943004/diff/60001/ui/views/controls/link.cc
File ui/views/controls/link.cc (right):

https://codereview.chromium.org/2609943004/diff/60001/ui/views/controls/link....
ui/views/controls/link.cc:130: return (event.key_code() == ui::VKEY_SPACE) ||
On 2017/01/05 02:26:54, tapted wrote:
> nit: the parens around this `==` look odd

Done.

[commit-bot: I haz the power, 2017-01-05 11:15:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 12:30:25]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1483614932222820,
"parent_rev": "bf37a67e87c690a6a2809c232dcbe5614e511708", "commit_rev":
"3da0435e15d762ba56ab91d08f3ccd63efedbeab"}

[commit-bot: I haz the power, 2017-01-05 12:30:54]

Description was changed from

==========
MacViews: Don't click views::Link on pressing Return key.

On Mac, the Return key is used to perform the default action associated with a
dialog even when a control is focused. Modify Link::OnKeyPressed and
Link::SkipDefaultKeyEventProcessing to respect the value of
PlatformStyle::kReturnClicksFocusedControl so that focused links are not clicked
on pressing Return. Instead on MacViews, Return is treated as an accelerator and
performs the default action.

BUG=607430
TEST=On Mac, enable chrome://flags/#secondary-ui-md. Open the Bookmark Bubble.
Enable Full Keyboard Access (Ctrl+F7). Ensure no user is signed onto Chromium.
Focus the "sign in to Chromium." link. Press Return key. Ensure the link is not
clicked. Instead, the default action is performed (associated with the Done
button).
==========

to

==========
MacViews: Don't click views::Link on pressing Return key.

On Mac, the Return key is used to perform the default action associated with a
dialog even when a control is focused. Modify Link::OnKeyPressed and
Link::SkipDefaultKeyEventProcessing to respect the value of
PlatformStyle::kReturnClicksFocusedControl so that focused links are not clicked
on pressing Return. Instead on MacViews, Return is treated as an accelerator and
performs the default action.

BUG=607430
TEST=On Mac, enable chrome://flags/#secondary-ui-md. Open the Bookmark Bubble.
Enable Full Keyboard Access (Ctrl+F7). Ensure no user is signed onto Chromium.
Focus the "sign in to Chromium." link. Press Return key. Ensure the link is not
clicked. Instead, the default action is performed (associated with the Done
button).

Review-Url: https://codereview.chromium.org/2609943004
Cr-Commit-Position: refs/heads/master@{#441626}
Committed:
https://chromium.googlesource.com/chromium/src/+/3da0435e15d762ba56ab91d08f3c...
==========

[commit-bot: I haz the power, 2017-01-05 12:30:56]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/3da0435e15d762ba56ab91d08f3c...