Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2609933003: MD History: Fix position of Clear Browsing Data menu promo (Closed)

Created:
3 years, 11 months ago by tsergeant
Modified:
3 years, 11 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, asanka, dbeam+watch-elements_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-downloads_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Fix position of Clear Browsing Data menu promo The positioning of the menu promo in MD History was accidentally broken in crrev.com/439710 when the layout of the left section of the toolbar was changed. BUG=677902 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/4df758bcc8a02b815277caf9979e2d7dabc4d36f Cr-Commit-Position: refs/heads/master@{#441439}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/resources/md_downloads/vulcanized.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 chunk +1 line, -0 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
tsergeant
PTAL!
3 years, 11 months ago (2017-01-04 05:42:16 UTC) #4
Dan Beam
lgtm
3 years, 11 months ago (2017-01-04 19:53:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609933003/1
3 years, 11 months ago (2017-01-04 19:54:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 20:02:50 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 20:06:47 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4df758bcc8a02b815277caf9979e2d7dabc4d36f
Cr-Commit-Position: refs/heads/master@{#441439}

Powered by Google App Engine
This is Rietveld 408576698