Use runAfterLayoutAndPaint instead of requestAnimationFrame and

Replace unsafe use of requestAnimationFrame and setTimeout in layout test.

Use runAfterLayoutAndPaint instead of requestAnimationFrame and
setTimeout(..., 0) as it's simpler and will continue to work when
setTimeout no longer waits at least 1ms.

BUG=402694
Committed: https://crrev.com/e0a0a27614fda9738ab167ef2dfde92ff7d5b58f
Cr-Commit-Position: refs/heads/master@{#441355}

[Dan Elphick, 2017-01-03 17:34:13]

The CQ bit was checked by delphick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-03 17:34:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Elphick, 2017-01-03 17:38:50]

Description was changed from

==========
Use runAfterLayoutAndPaint instead of requestAnimationFrame and
setTimeout(..., 0) as it's simpler and will continue to work when
setTimeout no longer waits at least 1ms.

BUG=402694
==========

to

==========
Use runAfterLayoutAndPaint instead of requestAnimationFrame and
setTimeout(..., 0) as it's simpler and will continue to work when
setTimeout no longer waits at least 1ms.

BUG=402694
==========

[Dan Elphick, 2017-01-03 17:38:50]

delphick@chromium.org changed reviewers:
+ majidvp@chromium.org

[Dan Elphick, 2017-01-03 17:40:56]

FYI:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/Hn3GxRLXmR0/XP9xcY_g...
has a discussion of the correct way to use requestAnimationFrame and setTimeout
to execute after a frame is displayed, but runAfterLayoutAndPaint is simpler.

[majidvp, 2017-01-03 18:22:03]

On 2017/01/03 17:40:56, delphick wrote:
> FYI:
>
https://groups.google.com/a/chromium.org/d/msg/blink-dev/Hn3GxRLXmR0/XP9xcY_g...
> has a discussion of the correct way to use requestAnimationFrame and
setTimeout
> to execute after a frame is displayed, but runAfterLayoutAndPaint is simpler.

lgtm with nits.

nit: Please format the description so that the first line is < 80 lines.


Very interesting thread. For the record, there is also [1]
which discusses better alternatives to setTimeout(..,0)

[1]
https://docs.google.com/document/d/1Yl4SnTLBWmY1O99_BTtQvuoffP8YM9HZx2YPkEsad...

[majidvp, 2017-01-03 18:22:14]

https://codereview.chromium.org/2609923002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/events/touch/touch-rect-crash-on-unpromote-layer.html
(right):

https://codereview.chromium.org/2609923002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/events/touch/touch-rect-crash-on-unpromote-layer.html:42:
// Verify we now have a hit rect on the document after waiting a frame.
nit: this comment is not longer accurate because we are not waiting for a frame
but rather a layout & paint phase. Please update to reflect this.

[commit-bot: I haz the power, 2017-01-03 18:35:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 18:35:01]

Dry run: This issue passed the CQ dry run.

[Dan Elphick, 2017-01-04 09:17:43]

Description was changed from

==========
Use runAfterLayoutAndPaint instead of requestAnimationFrame and
setTimeout(..., 0) as it's simpler and will continue to work when
setTimeout no longer waits at least 1ms.

BUG=402694
==========

to

==========
Replace unsafe use of requestAnimationFrame and setTimeout in layout test.

Use runAfterLayoutAndPaint instead of requestAnimationFrame and
setTimeout(..., 0) as it's simpler and will continue to work when
setTimeout no longer waits at least 1ms.

BUG=402694
==========

[Dan Elphick, 2017-01-04 09:22:29]

https://codereview.chromium.org/2609923002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/events/touch/touch-rect-crash-on-unpromote-layer.html
(right):

https://codereview.chromium.org/2609923002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/events/touch/touch-rect-crash-on-unpromote-layer.html:42:
// Verify we now have a hit rect on the document after waiting a frame.
On 2017/01/03 18:22:14, majidvp wrote:
> nit: this comment is not longer accurate because we are not waiting for a
frame
> but rather a layout & paint phase. Please update to reflect this.

Done.

[Dan Elphick, 2017-01-04 09:23:07]

The CQ bit was checked by delphick@chromium.org

[Dan Elphick, 2017-01-04 09:23:08]

The patchset sent to the CQ was uploaded after l-g-t-m from majidvp@chromium.org
Link to the patchset: https://codereview.chromium.org/2609923002/#ps20001
(title: "update comment")

[commit-bot: I haz the power, 2017-01-04 09:23:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 11:19:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483521787731840,
"parent_rev": "7a4d8ecb105c73d634fab67b3d0e64404eeded44", "commit_rev":
"f2b32f19807984329663e1a63d098ba27b171ebc"}

[commit-bot: I haz the power, 2017-01-04 11:19:50]

Description was changed from

==========
Replace unsafe use of requestAnimationFrame and setTimeout in layout test.

Use runAfterLayoutAndPaint instead of requestAnimationFrame and
setTimeout(..., 0) as it's simpler and will continue to work when
setTimeout no longer waits at least 1ms.

BUG=402694
==========

to

==========
Replace unsafe use of requestAnimationFrame and setTimeout in layout test.

Use runAfterLayoutAndPaint instead of requestAnimationFrame and
setTimeout(..., 0) as it's simpler and will continue to work when
setTimeout no longer waits at least 1ms.

BUG=402694

Review-Url: https://codereview.chromium.org/2609923002
==========

[commit-bot: I haz the power, 2017-01-04 11:19:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-04 11:21:45]

Description was changed from

==========
Replace unsafe use of requestAnimationFrame and setTimeout in layout test.

Use runAfterLayoutAndPaint instead of requestAnimationFrame and
setTimeout(..., 0) as it's simpler and will continue to work when
setTimeout no longer waits at least 1ms.

BUG=402694

Review-Url: https://codereview.chromium.org/2609923002
==========

to

==========
Replace unsafe use of requestAnimationFrame and setTimeout in layout test.

Use runAfterLayoutAndPaint instead of requestAnimationFrame and
setTimeout(..., 0) as it's simpler and will continue to work when
setTimeout no longer waits at least 1ms.

BUG=402694

Committed: https://crrev.com/e0a0a27614fda9738ab167ef2dfde92ff7d5b58f
Cr-Commit-Position: refs/heads/master@{#441355}
==========

[commit-bot: I haz the power, 2017-01-04 11:21:45]

Patchset 2 (id:??) landed as
https://crrev.com/e0a0a27614fda9738ab167ef2dfde92ff7d5b58f
Cr-Commit-Position: refs/heads/master@{#441355}