Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2609833003: Add support for idle tasks to the default platform (Closed)

Created:
3 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add support for idle tasks to the default platform BUG= Review-Url: https://codereview.chromium.org/2609833003 Cr-Commit-Position: refs/heads/master@{#42022} Committed: https://chromium.googlesource.com/v8/v8/+/1795343f3c0ff1f43bdde3e5f16cd65c0882ae67

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Patch Set 4 : updates #

Patch Set 5 : updates #

Patch Set 6 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -7 lines) Patch
M include/libplatform/libplatform.h View 1 chunk +11 lines, -0 lines 0 comments Download
M src/d8.cc View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M src/libplatform/default-platform.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M src/libplatform/default-platform.cc View 1 2 3 5 chunks +42 lines, -6 lines 0 comments Download
M test/unittests/libplatform/default-platform-unittest.cc View 1 2 3 4 5 2 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (28 generated)
jochen (gone - plz use gerrit)
ptal d8 doesn't really have a notion of idle time, but we just pretend we ...
3 years, 11 months ago (2017-01-03 08:33:51 UTC) #26
Benedikt Meurer
LGTM.
3 years, 11 months ago (2017-01-03 08:35:44 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609833003/100001
3 years, 11 months ago (2017-01-03 08:40:04 UTC) #29
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 08:41:45 UTC) #32
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/1795343f3c0ff1f43bdde3e5f16cd65c088...

Powered by Google App Engine
This is Rietveld 408576698