Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2609773003: Revert of [Compiler] Track Ignition background compilation separately in RuntimeStats. (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
CC:
jochen (gone - plz use gerrit), v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Compiler] Track Ignition background compilation separately in RuntimeStats. (patchset #3 id:80001 of https://codereview.chromium.org/2577263002/ ) Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/13358 Original issue's description: > [Compiler] Track Ignition background compilation separately in RuntimeStats. > > Tracks background compilation of Ignition in a separate bucket from main thread > compilation. Also add some more compilation buckets for functions which can take a > significant proportion of compilation. > > BUG=v8:5203, v8:5215 > > Review-Url: https://codereview.chromium.org/2577263002 > Cr-Commit-Position: refs/heads/master@{#42026} > Committed: https://chromium.googlesource.com/v8/v8/+/b0e9116d59326a4f9a4f4691b61a510e342338c9 TBR=jochen@chromium.org,cbruni@chromium.org,rmcilroy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5203, v8:5215 Review-Url: https://codereview.chromium.org/2609773003 Cr-Commit-Position: refs/heads/master@{#42031} Committed: https://chromium.googlesource.com/v8/v8/+/8ad1e681e387b8362189bbd5e1130c894652050c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -82 lines) Patch
M src/compiler.h View 3 chunks +1 line, -8 lines 0 comments Download
M src/compiler.cc View 5 chunks +2 lines, -9 lines 0 comments Download
M src/counters.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/interpreter/interpreter.cc View 4 chunks +6 lines, -49 lines 0 comments Download
M tools/callstats.html View 2 chunks +0 lines, -3 lines 0 comments Download
M tools/callstats.py View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [Compiler] Track Ignition background compilation separately in RuntimeStats.
3 years, 11 months ago (2017-01-03 14:05:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609773003/1
3 years, 11 months ago (2017-01-03 14:05:36 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/8ad1e681e387b8362189bbd5e1130c894652050c
3 years, 11 months ago (2017-01-03 14:05:49 UTC) #6
rmcilroy
3 years, 11 months ago (2017-01-03 15:15:14 UTC) #7
Message was sent while issue was closed.
On 2017/01/03 14:05:49, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/v8/v8/+/8ad1e681e387b8362189bbd5e1130c89465...

Thanks for the revert Michael.

Powered by Google App Engine
This is Rietveld 408576698