|
|
DescriptionUse TaskScheduler instead of WorkerPool in gbm_surfaceless.cc.
This CL was reverted because it posted a task to TaskScheduler
before it was initialized. This issue was addressed in
https://crbug.com/690706.
The following traits are used:
Priority: Inherited (default)
The priority is inherited from the calling context (i.e. TaskTraits
are initialized with the priority of the current task).
Shutdown behavior: CONTINUE_ON_SHUTDOWN
Tasks posted with this mode which have not started executing before
shutdown is initiated will never run. Tasks with this mode running at
shutdown will be ignored (the worker will not be joined).
Note: Tasks that were previously posted to base::WorkerPool should
use this shutdown behavior because this is how base::WorkerPool
handles all its tasks.
May Block:
Tasks posted with MayBlock() may block. This includes but is not
limited to tasks that wait on synchronous file I/O operations:
read or write a file from disk, interact with a pipe or a socket,
rename or delete a file, enumerate files in a directory, etc. This
trait isn't required for the mere use of locks.
BUG=659191
Committed: https://crrev.com/0127fd25bd985f1f5f87c0a7c060d3159142086a
Cr-Original-Commit-Position: refs/heads/master@{#441139}
Review-Url: https://codereview.chromium.org/2609733002
Cr-Commit-Position: refs/heads/master@{#468713}
Committed: https://chromium.googlesource.com/chromium/src/+/2fd356a58dfbc3e653f2c4eb3f781cb6a88c3472
Patch Set 1 #Patch Set 2 : fix build error #Messages
Total messages: 25 (16 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
fdoray@chromium.org changed reviewers: + dnicoara@chromium.org
PTAL. WorkerPool is being deprecated in favor of TaskScheduler.
lgtm
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483461818253890, "parent_rev": "c9c544f27ff9c433a481fd26837e97a63583edba", "commit_rev": "ad7e1bfd17cec009c50ce0b7b94a4842bbca6e8d"}
Message was sent while issue was closed.
Description was changed from ========== Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=659191 ========== to ========== Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=659191 Review-Url: https://codereview.chromium.org/2609733002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=659191 Review-Url: https://codereview.chromium.org/2609733002 ========== to ========== Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=659191 Committed: https://crrev.com/0127fd25bd985f1f5f87c0a7c060d3159142086a Cr-Commit-Position: refs/heads/master@{#441139} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/0127fd25bd985f1f5f87c0a7c060d3159142086a Cr-Commit-Position: refs/heads/master@{#441139}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2612853002/ by afakhry@chromium.org. The reason for reverting is: Causes the UI to crash on peach_pit and multiple HWTest failures on the PFQ and the informational builder. See BUG=678296..
Message was sent while issue was closed.
Description was changed from ========== Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=659191 Committed: https://crrev.com/0127fd25bd985f1f5f87c0a7c060d3159142086a Cr-Commit-Position: refs/heads/master@{#441139} ========== to ========== Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=659191 Committed: https://crrev.com/0127fd25bd985f1f5f87c0a7c060d3159142086a Cr-Commit-Position: refs/heads/master@{#441139} ==========
Description was changed from ========== Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=659191 Committed: https://crrev.com/0127fd25bd985f1f5f87c0a7c060d3159142086a Cr-Commit-Position: refs/heads/master@{#441139} ========== to ========== Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc. This CL was reverted because it posted a task to TaskScheduler before it was initialized. This issue was addressed in https://crbug.com/690706. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=659191 Committed: https://crrev.com/0127fd25bd985f1f5f87c0a7c060d3159142086a Cr-Commit-Position: refs/heads/master@{#441139} ==========
Relanding. This CL was reverted because it posted a task to TaskScheduler before it was initialized. This issue was addressed in https://crbug.com/690706.
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493748341762220, "parent_rev": "08fb0ca7077abf9c7ddfce597a4015244b16d434", "commit_rev": "2fd356a58dfbc3e653f2c4eb3f781cb6a88c3472"}
Message was sent while issue was closed.
Description was changed from ========== Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc. This CL was reverted because it posted a task to TaskScheduler before it was initialized. This issue was addressed in https://crbug.com/690706. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=659191 Committed: https://crrev.com/0127fd25bd985f1f5f87c0a7c060d3159142086a Cr-Commit-Position: refs/heads/master@{#441139} ========== to ========== Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc. This CL was reverted because it posted a task to TaskScheduler before it was initialized. This issue was addressed in https://crbug.com/690706. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=659191 Committed: https://crrev.com/0127fd25bd985f1f5f87c0a7c060d3159142086a Cr-Original-Commit-Position: refs/heads/master@{#441139} Review-Url: https://codereview.chromium.org/2609733002 Cr-Commit-Position: refs/heads/master@{#468713} Committed: https://chromium.googlesource.com/chromium/src/+/2fd356a58dfbc3e653f2c4eb3f78... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/2fd356a58dfbc3e653f2c4eb3f78... |