Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 2609733002: [reland] Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc. (Closed)

Created:
3 years, 11 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
dnicoara
CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc. This CL was reverted because it posted a task to TaskScheduler before it was initialized. This issue was addressed in https://crbug.com/690706. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=659191 Committed: https://crrev.com/0127fd25bd985f1f5f87c0a7c060d3159142086a Cr-Original-Commit-Position: refs/heads/master@{#441139} Review-Url: https://codereview.chromium.org/2609733002 Cr-Commit-Position: refs/heads/master@{#468713} Committed: https://chromium.googlesource.com/chromium/src/+/2fd356a58dfbc3e653f2c4eb3f781cb6a88c3472

Patch Set 1 #

Patch Set 2 : fix build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M ui/ozone/platform/drm/gpu/gbm_surfaceless.cc View 1 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 25 (16 generated)
fdoray
PTAL. WorkerPool is being deprecated in favor of TaskScheduler.
3 years, 11 months ago (2017-01-01 23:18:35 UTC) #8
dnicoara
lgtm
3 years, 11 months ago (2017-01-03 15:52:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609733002/20001
3 years, 11 months ago (2017-01-03 16:43:52 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-03 17:07:37 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0127fd25bd985f1f5f87c0a7c060d3159142086a Cr-Commit-Position: refs/heads/master@{#441139}
3 years, 11 months ago (2017-01-03 17:10:31 UTC) #16
afakhry
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2612853002/ by afakhry@chromium.org. ...
3 years, 11 months ago (2017-01-04 19:23:08 UTC) #17
fdoray
Relanding. This CL was reverted because it posted a task to TaskScheduler before it was ...
3 years, 7 months ago (2017-05-02 18:05:34 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609733002/20001
3 years, 7 months ago (2017-05-02 18:06:06 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 18:42:46 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2fd356a58dfbc3e653f2c4eb3f78...

Powered by Google App Engine
This is Rietveld 408576698