Use "derived" instead of "subclass" in FunctionKind to match the spec

Use "derived" instead of "subclass" in FunctionKind to match the spec

TBR=bmeurer@chromium.org

Review-Url: https://codereview.chromium.org/2609663002
Cr-Commit-Position: refs/heads/master@{#42047}
Committed: https://chromium.googlesource.com/v8/v8/+/db7f0169f5cca3beb64f7460527bbd508a0fb94a

[Dan Ehrenberg, 2016-12-30 11:07:00]

lgtm

We should do more of this.

[adamk, 2017-01-03 18:23:38]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2017-01-03 18:23:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 18:26:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 18:26:51]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/31579)

[adamk, 2017-01-03 18:46:51]

Description was changed from

==========
Use "derived" instead of "subclass" in FunctionKind to match the spec

R=littledan@chromium.org
==========

to

==========
Use "derived" instead of "subclass" in FunctionKind to match the spec

TBR=bmeurer@chromium.org
==========

[adamk, 2017-01-03 18:46:52]

adamk@chromium.org changed reviewers:
+ bmeurer@chromium.org

[adamk, 2017-01-03 18:47:05]

TBR bmeurer for crankshaft, this is a straight rename.

[adamk, 2017-01-03 18:47:08]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2017-01-03 18:47:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 18:56:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 18:56:33]

Failed to apply patch for src/parsing/parser.cc:
While running git apply --index -p1;
  error: patch failed: src/parsing/parser.cc:173
  error: src/parsing/parser.cc: patch does not apply

Patch:       src/parsing/parser.cc
Index: src/parsing/parser.cc
diff --git a/src/parsing/parser.cc b/src/parsing/parser.cc
index
5a54bd9abc34ffa2a83393fc9c8878aff904b8b8..75b63981b1d5ed0f32a3964699fd95e2cdd01302
100644
--- a/src/parsing/parser.cc
+++ b/src/parsing/parser.cc
@@ -173,7 +173,7 @@ FunctionLiteral* Parser::DefaultConstructor(const
AstRawString* name,
   const int parameter_count = 0;
   if (name == nullptr) name = ast_value_factory()->empty_string();
 
-  FunctionKind kind = call_super ? FunctionKind::kDefaultSubclassConstructor
+  FunctionKind kind = call_super ? FunctionKind::kDefaultDerivedConstructor
                                  : FunctionKind::kDefaultBaseConstructor;
   DeclarationScope* function_scope = NewFunctionScope(kind);
   SetLanguageMode(function_scope,
@@ -937,7 +937,7 @@ FunctionLiteral* Parser::DoParseFunction(ParseInfo* info,
       }
     } else if (IsDefaultConstructor(kind)) {
       DCHECK_EQ(scope(), outer);
-      bool is_subclass_constructor = IsSubclassConstructor(kind);
+      bool is_subclass_constructor = IsDerivedConstructor(kind);
       result = DefaultConstructor(raw_name, is_subclass_constructor,
                                   info->start_position(), info->end_position(),
                                   info->language_mode());
@@ -1581,7 +1581,7 @@ bool Parser::ContainsLabel(ZoneList<const AstRawString*>*
labels,
 }
 
 Expression* Parser::RewriteReturn(Expression* return_value, int pos) {
-  if (IsSubclassConstructor(function_state_->kind())) {
+  if (IsDerivedConstructor(function_state_->kind())) {
     // For subclass constructors we need to return this in case of undefined
     // return a Smi (transformed into an exception in the ConstructStub)
     // for a non object.
@@ -3198,7 +3198,7 @@ ZoneList<Statement*>* Parser::ParseEagerFunctionBody(
       ParseStatementList(body, Token::RBRACE, CHECK_OK);
     }
 
-    if (IsSubclassConstructor(kind)) {
+    if (IsDerivedConstructor(kind)) {
      
body->Add(factory()->NewReturnStatement(ThisExpression(kNoSourcePosition),
                                               kNoSourcePosition),
                 zone());

[adamk, 2017-01-03 19:11:02]

The CQ bit was checked by adamk@chromium.org

[adamk, 2017-01-03 19:11:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
littledan@chromium.org
Link to the patchset: https://codereview.chromium.org/2609663002/#ps20001
(title: "Rebased")

[commit-bot: I haz the power, 2017-01-03 19:11:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2017-01-03 19:27:12]

LGTM.

[commit-bot: I haz the power, 2017-01-03 19:37:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483470662507330,
"parent_rev": "7d52258b1db78cf8de165f6494dd806d62ccbb81", "commit_rev":
"db7f0169f5cca3beb64f7460527bbd508a0fb94a"}

[commit-bot: I haz the power, 2017-01-03 19:37:29]

Description was changed from

==========
Use "derived" instead of "subclass" in FunctionKind to match the spec

TBR=bmeurer@chromium.org
==========

to

==========
Use "derived" instead of "subclass" in FunctionKind to match the spec

TBR=bmeurer@chromium.org

Review-Url: https://codereview.chromium.org/2609663002
Cr-Commit-Position: refs/heads/master@{#42047}
Committed:
https://chromium.googlesource.com/v8/v8/+/db7f0169f5cca3beb64f7460527bbd508a0...
==========

[commit-bot: I haz the power, 2017-01-03 19:37:30]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/db7f0169f5cca3beb64f7460527bbd508a0...