Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2609593002: MD Settings: Internet: Minor fixes (Closed)

Created:
3 years, 11 months ago by stevenjb
Modified:
3 years, 11 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Internet: Minor fixes * 'Forget' always closes the details page since the GUID will be invalid * 'Nameservers' -> 'Name servers' BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/3b87e47e56a7f5cdba3948ac973acb4558e2d9d9 Cr-Commit-Position: refs/heads/master@{#441238}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/app/settings_strings.grdp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_detail_page.js View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
stevenjb
3 years, 11 months ago (2016-12-29 21:40:40 UTC) #3
michaelpg
lgtm https://codereview.chromium.org/2609593002/diff/1/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2609593002/diff/1/chrome/app/settings_strings.grdp#newcode1070 chrome/app/settings_strings.grdp:1070: <message name="IDS_SETTINGS_INTERNET_NETWORK_SECTION_NAMESERVERS" desc="Settings > Internet > Network details: ...
3 years, 11 months ago (2017-01-03 20:43:53 UTC) #4
stevenjb
https://codereview.chromium.org/2609593002/diff/1/chrome/app/settings_strings.grdp File chrome/app/settings_strings.grdp (right): https://codereview.chromium.org/2609593002/diff/1/chrome/app/settings_strings.grdp#newcode1070 chrome/app/settings_strings.grdp:1070: <message name="IDS_SETTINGS_INTERNET_NETWORK_SECTION_NAMESERVERS" desc="Settings > Internet > Network details: Nameservers ...
3 years, 11 months ago (2017-01-03 21:32:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609593002/20001
3 years, 11 months ago (2017-01-03 21:33:36 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-03 23:09:01 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 23:13:19 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3b87e47e56a7f5cdba3948ac973acb4558e2d9d9
Cr-Commit-Position: refs/heads/master@{#441238}

Powered by Google App Engine
This is Rietveld 408576698