Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issue 2609553002: Gracefully handle MADV_FREE available at compile time but not run time (Closed)

Created:
3 years, 11 months ago by Paweł Hajdan Jr.
Modified:
3 years, 11 months ago
Reviewers:
palmer, haraken
CC:
chromium-reviews, Dai Mikurube (NOT FULLTIME), vmpstr+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gracefully handle MADV_FREE available at compile time but not run time This fixes "aw snap" with glibc-2.24 . BUG=636229 Committed: https://crrev.com/447a7a69008678046379b35bc14faad91ad2812f Cr-Commit-Position: refs/heads/master@{#441020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M base/allocator/partition_allocator/page_allocator.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Paweł Hajdan Jr.
3 years, 11 months ago (2016-12-29 17:56:10 UTC) #6
palmer
lgtm
3 years, 11 months ago (2016-12-29 20:18:55 UTC) #7
haraken
LGTM
3 years, 11 months ago (2016-12-30 00:07:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609553002/1
3 years, 11 months ago (2016-12-30 07:43:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-30 07:48:05 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:54:13 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/447a7a69008678046379b35bc14faad91ad2812f
Cr-Commit-Position: refs/heads/master@{#441020}

Powered by Google App Engine
This is Rietveld 408576698