Issue 2609543002: Refactor setup of background upload alert from MC to separate file.

Issue 2609543002: Refactor setup of background upload alert from MC to separate file. (Closed)

Created:
3 years, 11 months ago by lody

Modified:
3 years, 11 months ago

Reviewers:
marq (ping after 24h)

CC:
chromium-reviews, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Refactor setup of background upload alert from MC to separate file. BUG=663359 Committed: https://crrev.com/58690f83f33422ac2f134a6275f2e364306113cc Cr-Commit-Position: refs/heads/master@{#440958}

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -12 lines)			Patch
M	ios/chrome/app/main_controller.mm	View	2 chunks	+2 lines, -12 lines	0 comments	Download
M	ios/chrome/app/startup/BUILD.gn	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	ios/chrome/app/startup/background_upload_alert.h	View	1 chunk	+16 lines, -0 lines	0 comments	Download
A	ios/chrome/app/startup/background_upload_alert.mm	View	1 chunk	+26 lines, -0 lines	0 comments	Download

Total messages: 10 (5 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609543002/1

3 years, 11 months ago (2016-12-29 14:52:24 UTC) #5

commit-bot: I haz the power

3 years, 11 months ago (2017-01-02 15:52:20 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/58690f83f33422ac2f134a6275f2e364306113cc
Cr-Commit-Position: refs/heads/master@{#440958}