Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2609493002: Landing Recent QUIC changes until 05:15 PM, Dec 24, 2016 UTC (Closed)

Created:
3 years, 11 months ago by Jana
Modified:
3 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Landing Recent QUIC changes until 05:15 PM, Dec 24, 2016 UTC Include quic_str_cat.h in all the places it's used. Merge internal change: 142874387 https://codereview.chromium.org/2609483002/ QUIC - refactor in preparation for two streams per HTTP transaction. The IETF WG is moving to model of using a pair of streams per https://quicwg.github.io/base-drafts/draft-ietf-quic-http.html#rfc.section.4.2 This scheme above came about in the course of discussions on QUIC specific changes to HPACK that will hopefully eliminate HPACK induced HoL blocking. This change is a refactor of QuicHeadersStream and QuicSpdySession, moving per-session granularity items from the former to the latter. It does not yet make headers stream per request, but this helps prepare the way. na/ (refactor only - no functional change). Merge internal change: 142825457 https://codereview.chromium.org/2607873002/ BUG= Committed: https://crrev.com/a08ea6fbebc83ed40f6ac9cfd6210df0eae4e5a0 Cr-Commit-Position: refs/heads/master@{#440936}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Format #

Patch Set 4 : Fix random. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+917 lines, -895 lines) Patch
M net/net.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_headers_stream.h View 1 chunk +0 lines, -126 lines 0 comments Download
M net/quic/core/quic_headers_stream.cc View 1 2 4 chunks +2 lines, -588 lines 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 1 15 chunks +26 lines, -30 lines 0 comments Download
M net/quic/core/quic_session_test.cc View 1 2 3 3 chunks +5 lines, -6 lines 0 comments Download
M net/quic/core/quic_spdy_session.h View 7 chunks +148 lines, -0 lines 0 comments Download
M net/quic/core/quic_spdy_session.cc View 6 chunks +581 lines, -5 lines 0 comments Download
M net/quic/core/quic_spdy_stream.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_stream.h View 2 chunks +1 line, -1 line 0 comments Download
D net/quic/test_tools/quic_headers_stream_peer.h View 1 chunk +0 lines, -28 lines 0 comments Download
D net/quic/test_tools/quic_headers_stream_peer.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M net/quic/test_tools/quic_spdy_session_peer.h View 2 chunks +19 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_spdy_session_peer.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M net/tools/quic/quic_simple_server_session.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 1 12 chunks +80 lines, -73 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 3 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Jana
3 years, 11 months ago (2016-12-29 02:23:15 UTC) #4
Ryan Hamilton
lgtm
3 years, 11 months ago (2016-12-29 03:24:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609493002/60001
3 years, 11 months ago (2016-12-29 03:48:34 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
3 years, 11 months ago (2016-12-29 04:45:33 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:51:42 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a08ea6fbebc83ed40f6ac9cfd6210df0eae4e5a0
Cr-Commit-Position: refs/heads/master@{#440936}

Powered by Google App Engine
This is Rietveld 408576698