Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2609453002: Drop default values from JS-specific .clang-format files (Closed)

Created:
3 years, 11 months ago by Dan Beam
Modified:
3 years, 11 months ago
Reviewers:
dcheng
CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop default values from JS-specific .clang-format files R=dcheng@chromium.org BUG=567770 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOTRY=true NO_DEPENDENCY_CHECKS=true Committed: https://crrev.com/cecce913ab8b2e416c22bc3383378a1a9520f70c Cr-Commit-Position: refs/heads/master@{#440894}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M chrome/browser/resources/.clang-format View 1 1 chunk +1 line, -6 lines 0 comments Download
M ui/webui/resources/.clang-format View 1 1 chunk +1 line, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
Dan Beam
btw, re-running clang-format on all of ui/webui/resources produced no diff before vs after
3 years, 11 months ago (2016-12-28 18:59:15 UTC) #2
dcheng
LGTM (I'd suggest hoisting the single-function conditional ban to the top level .clang-format though)
3 years, 11 months ago (2016-12-28 19:02:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609453002/20001
3 years, 11 months ago (2016-12-28 21:08:56 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2016-12-28 21:14:22 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:50:21 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cecce913ab8b2e416c22bc3383378a1a9520f70c
Cr-Commit-Position: refs/heads/master@{#440894}

Powered by Google App Engine
This is Rietveld 408576698