Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: xfa/fde/ifde_txtedtengine.h

Issue 2609423003: Properly ref-count CFGAS_GEFont with CFX_RetainPtr. (Closed)
Patch Set: comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« xfa/fde/fde_gedevice.h ('K') | « xfa/fde/fde_visualset.h ('k') | xfa/fde/tto/fde_textout.h » ('j') | xfa/fgas/font/cfgas_fontmgr.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fde/ifde_txtedtengine.h
diff --git a/xfa/fde/ifde_txtedtengine.h b/xfa/fde/ifde_txtedtengine.h
index 12f0cd88bfc9a563e539b384f22d75c529e72fdb..6940a8c7d684a10fa9810530dde9e712d05fe66c 100644
--- a/xfa/fde/ifde_txtedtengine.h
+++ b/xfa/fde/ifde_txtedtengine.h
@@ -72,6 +72,7 @@ enum FDE_TXTEDIT_LINEEND {
struct FDE_TXTEDTPARAMS {
FDE_TXTEDTPARAMS();
+ ~FDE_TXTEDTPARAMS();
FX_FLOAT fPlateWidth;
FX_FLOAT fPlateHeight;
@@ -79,7 +80,7 @@ struct FDE_TXTEDTPARAMS {
uint32_t dwLayoutStyles;
uint32_t dwAlignment;
uint32_t dwMode;
- CFGAS_GEFont* pFont;
+ CFX_RetainPtr<CFGAS_GEFont> pFont;
FX_FLOAT fFontSize;
FX_ARGB dwFontColor;
FX_FLOAT fLineSpace;
« xfa/fde/fde_gedevice.h ('K') | « xfa/fde/fde_visualset.h ('k') | xfa/fde/tto/fde_textout.h » ('j') | xfa/fgas/font/cfgas_fontmgr.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698