Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1422)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: xfa/fde/fde_visualset.h

Issue 2609423003: Properly ref-count CFGAS_GEFont with CFX_RetainPtr. (Closed)
Patch Set: comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« xfa/fde/fde_gedevice.h ('K') | « xfa/fde/fde_render.cpp ('k') | xfa/fde/ifde_txtedtengine.h » ('j') | xfa/fgas/font/cfgas_fontmgr.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fde/fde_visualset.h
diff --git a/xfa/fde/fde_visualset.h b/xfa/fde/fde_visualset.h
index 481f4a5cbb3601dfd17ce5d310cc97b9b7223566..77aa6c7253709c7569f65aef3fbad41bb2337633 100644
--- a/xfa/fde/fde_visualset.h
+++ b/xfa/fde/fde_visualset.h
@@ -7,6 +7,7 @@
#ifndef XFA_FDE_FDE_VISUALSET_H_
#define XFA_FDE_FDE_VISUALSET_H_
+#include "core/fxcrt/cfx_retain_ptr.h"
#include "core/fxcrt/fx_coordinates.h"
#include "core/fxcrt/fx_system.h"
#include "core/fxge/fx_dib.h"
@@ -48,7 +49,7 @@ class IFDE_TextSet : public IFDE_VisualSet {
public:
virtual int32_t GetString(FDE_TEXTEDITPIECE* hText,
CFX_WideString& wsText) = 0;
- virtual CFGAS_GEFont* GetFont() = 0;
+ virtual CFX_RetainPtr<CFGAS_GEFont> GetFont() = 0;
virtual FX_FLOAT GetFontSize() = 0;
virtual FX_ARGB GetFontColor() = 0;
virtual int32_t GetDisplayPos(FDE_TEXTEDITPIECE* hText,
« xfa/fde/fde_gedevice.h ('K') | « xfa/fde/fde_render.cpp ('k') | xfa/fde/ifde_txtedtengine.h » ('j') | xfa/fgas/font/cfgas_fontmgr.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698