Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1845)

Unified Diff: components/ntp_snippets/content_suggestions_metrics.h

Issue 2609413005: [NTP::SectionOrder] Add category position metric for opened suggestions. (Closed)
Patch Set: rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/content_suggestions_metrics.h
diff --git a/components/ntp_snippets/content_suggestions_metrics.h b/components/ntp_snippets/content_suggestions_metrics.h
index d03fb42a48bb91ce10549759459ea0a50983850a..12e2b46136e03bc8bf3545bdeb833d6054d0af3c 100644
--- a/components/ntp_snippets/content_suggestions_metrics.h
+++ b/components/ntp_snippets/content_suggestions_metrics.h
@@ -21,27 +21,30 @@ void OnPageShown(
// Should only be called once per NTP for each suggestion.
void OnSuggestionShown(int global_position,
Category category,
- int category_position,
+ int position_in_category,
base::Time publish_date,
base::Time last_background_fetch_time,
float score);
+// TODO(crbug.com/682160): Take struct, so that one could not mix up the
+// order of arguments.
void OnSuggestionOpened(int global_position,
Category category,
- int category_position,
+ int category_index,
+ int position_in_category,
base::Time publish_date,
float score,
WindowOpenDisposition disposition);
void OnSuggestionMenuOpened(int global_position,
Category category,
- int category_position,
+ int position_in_category,
base::Time publish_date,
float score);
void OnSuggestionDismissed(int global_position,
Category category,
- int category_position,
+ int position_in_category,
bool visited);
void OnSuggestionTargetVisited(Category category, base::TimeDelta visit_time);
« no previous file with comments | « chrome/browser/android/ntp/ntp_snippets_bridge.cc ('k') | components/ntp_snippets/content_suggestions_metrics.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698