Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: components/ntp_snippets/content_suggestions_metrics.h

Issue 2609413005: [NTP::SectionOrder] Add category position metric for opened suggestions. (Closed)
Patch Set: rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_METRICS_H_ 5 #ifndef COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_METRICS_H_
6 #define COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_METRICS_H_ 6 #define COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_METRICS_H_
7 7
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/time/time.h" 11 #include "base/time/time.h"
12 #include "components/ntp_snippets/category.h" 12 #include "components/ntp_snippets/category.h"
13 #include "ui/base/window_open_disposition.h" 13 #include "ui/base/window_open_disposition.h"
14 14
15 namespace ntp_snippets { 15 namespace ntp_snippets {
16 namespace metrics { 16 namespace metrics {
17 17
18 void OnPageShown( 18 void OnPageShown(
19 const std::vector<std::pair<Category, int>>& suggestions_per_category); 19 const std::vector<std::pair<Category, int>>& suggestions_per_category);
20 20
21 // Should only be called once per NTP for each suggestion. 21 // Should only be called once per NTP for each suggestion.
22 void OnSuggestionShown(int global_position, 22 void OnSuggestionShown(int global_position,
23 Category category, 23 Category category,
24 int category_position, 24 int position_in_category,
25 base::Time publish_date, 25 base::Time publish_date,
26 base::Time last_background_fetch_time, 26 base::Time last_background_fetch_time,
27 float score); 27 float score);
28 28
29 // TODO(crbug.com/682160): Take struct, so that one could not mix up the
30 // order of arguments.
29 void OnSuggestionOpened(int global_position, 31 void OnSuggestionOpened(int global_position,
30 Category category, 32 Category category,
31 int category_position, 33 int category_index,
34 int position_in_category,
32 base::Time publish_date, 35 base::Time publish_date,
33 float score, 36 float score,
34 WindowOpenDisposition disposition); 37 WindowOpenDisposition disposition);
35 38
36 void OnSuggestionMenuOpened(int global_position, 39 void OnSuggestionMenuOpened(int global_position,
37 Category category, 40 Category category,
38 int category_position, 41 int position_in_category,
39 base::Time publish_date, 42 base::Time publish_date,
40 float score); 43 float score);
41 44
42 void OnSuggestionDismissed(int global_position, 45 void OnSuggestionDismissed(int global_position,
43 Category category, 46 Category category,
44 int category_position, 47 int position_in_category,
45 bool visited); 48 bool visited);
46 49
47 void OnSuggestionTargetVisited(Category category, base::TimeDelta visit_time); 50 void OnSuggestionTargetVisited(Category category, base::TimeDelta visit_time);
48 51
49 // Should only be called once per NTP for each "more" button. 52 // Should only be called once per NTP for each "more" button.
50 void OnMoreButtonShown(Category category, int position); 53 void OnMoreButtonShown(Category category, int position);
51 54
52 void OnMoreButtonClicked(Category category, int position); 55 void OnMoreButtonClicked(Category category, int position);
53 56
54 void OnCategoryDismissed(Category category); 57 void OnCategoryDismissed(Category category);
55 58
56 } // namespace metrics 59 } // namespace metrics
57 } // namespace ntp_snippets 60 } // namespace ntp_snippets
58 61
59 #endif // COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_SERVICE_H_ 62 #endif // COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_SERVICE_H_
OLDNEW
« no previous file with comments | « chrome/browser/android/ntp/ntp_snippets_bridge.cc ('k') | components/ntp_snippets/content_suggestions_metrics.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698