Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Issue 2609413002: Simplify WorkerGlobalScope::m_eventListeners. (Closed)

Created:
3 years, 11 months ago by sof
Modified:
3 years, 11 months ago
CC:
blink-reviews, blink-worker-reviews_chromium.org, chromium-reviews, falken+watch_chromium.org, horo+watch_chromium.org, kinuko+worker_chromium.org, shimazu+worker_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify WorkerGlobalScope::m_eventListeners. Switch to using a 'mere' HashSet<> for these event listeners. Mainly done to diagnose GC instability, but removing the use of an involved abstraction like HeapListHashSet<> is something wanted regardless. R= BUG=677654 Committed: https://crrev.com/68a05927d5b6f315e26229deacabdabd5f754bf1 Cr-Commit-Position: refs/heads/master@{#441364}

Patch Set 1 #

Patch Set 2 : formatting #

Patch Set 3 : adjust deregister assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp View 1 2 2 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
sof
please take a look (and a happy new year :) ) There's a general increase ...
3 years, 11 months ago (2017-01-04 13:10:29 UTC) #9
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-04 13:19:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2609413002/40001
3 years, 11 months ago (2017-01-04 13:36:10 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 11 months ago (2017-01-04 13:40:26 UTC) #17
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/68a05927d5b6f315e26229deacabdabd5f754bf1 Cr-Commit-Position: refs/heads/master@{#441364}
3 years, 11 months ago (2017-01-04 13:42:32 UTC) #19
haraken
3 years, 11 months ago (2017-01-04 14:29:02 UTC) #20
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698