Only allow extra space if scroll below the fold experiment is enabled.

Only allow extra space if scroll below the fold experiment is enabled.

BUG=677908
Review-Url: https://codereview.chromium.org/2609403006
Cr-Commit-Position: refs/heads/master@{#441915}
Committed: https://chromium.googlesource.com/chromium/src/+/f301af7c3beee3ce379c74079610c8574e7f6bf0

[Michael van Ouwerkerk, 2017-01-05 16:44:10]

The CQ bit was checked by mvanouwerkerk@chromium.org to run a CQ dry run

[Michael van Ouwerkerk, 2017-01-05 16:44:26]

mvanouwerkerk@chromium.org changed reviewers:
+ bauerb@chromium.org

[Michael van Ouwerkerk, 2017-01-05 16:44:27]

Bernhard, could you take a look please?

[commit-bot: I haz the power, 2017-01-05 16:44:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 17:18:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 17:18:52]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-01-05 18:52:29]

lgtm

https://codereview.chromium.org/2609403006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
(right):

https://codereview.chromium.org/2609403006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java:239:
boolean allowSpaceForInitiallyScrollingBelowTheFold =
Maybe explain the reasoning behind this?

[Michael van Ouwerkerk, 2017-01-06 10:30:13]

https://codereview.chromium.org/2609403006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java
(right):

https://codereview.chromium.org/2609403006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java:239:
boolean allowSpaceForInitiallyScrollingBelowTheFold =
On 2017/01/05 18:52:29, Bernhard Bauer wrote:
> Maybe explain the reasoning behind this?

Done.

[Michael van Ouwerkerk, 2017-01-06 10:30:16]

The CQ bit was checked by mvanouwerkerk@chromium.org

[Michael van Ouwerkerk, 2017-01-06 10:30:17]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2609403006/#ps20001
(title: "Add comment.")

[commit-bot: I haz the power, 2017-01-06 10:30:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 11:02:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483698616511330,
"parent_rev": "e827c1a786ea596461b2c76ba6dafffd40f1bec8", "commit_rev":
"f301af7c3beee3ce379c74079610c8574e7f6bf0"}

[commit-bot: I haz the power, 2017-01-06 11:02:42]

Description was changed from

==========
Only allow extra space if scroll below the fold experiment is enabled.

BUG=677908
==========

to

==========
Only allow extra space if scroll below the fold experiment is enabled.

BUG=677908

Review-Url: https://codereview.chromium.org/2609403006
Cr-Commit-Position: refs/heads/master@{#441915}
Committed:
https://chromium.googlesource.com/chromium/src/+/f301af7c3beee3ce379c74079610...
==========

[commit-bot: I haz the power, 2017-01-06 11:02:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f301af7c3beee3ce379c74079610...